Skip to content

Commit ac26901

Browse files
committed
chore: remove ms-choice control border hover color
- most framework don't have border hover color, and a border-color is easy to add but super hard (impossible?) to remove (tried inherit, unset, initial), so let's remove it and let users configure it themselves
1 parent da91b46 commit ac26901

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

packages/demo/src/style.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ $side-menu-width: 250px;
2828
--bs-nav-link-font-size: 14px;
2929
}
3030

31+
.ms-choice:hover {
32+
border-color: #b7b7b7;
33+
}
34+
3135
.cloak {
3236
visibility: 'hidden';
3337
}

packages/multiple-select-vanilla/src/styles/_variables.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ $ms-checkbox-icon-container-border: 1px solid #d0d0d0 !default;
1818
$ms-checkbox-icon-container-height: 1.05rem !default;
1919
$ms-checkbox-icon-container-width: 1.05rem !default;
2020
$ms-choice-border: 1px solid #d0d0d0 !default;
21-
$ms-choice-border-hover-color: #c3c3c3 !default;
2221
$ms-choice-border-radius: 4px !default;
2322
$ms-choice-bgcolor: #fff !default;
2423
$ms-choice-color: #444 !default;
@@ -121,7 +120,6 @@ $ms-select-all-text-hover-color: transparent !default;
121120
--ms-choice-border: 1px solid #757575;
122121
--ms-choice-bgcolor: #262b2f;
123122
--ms-choice-color: #d4d4d4;
124-
--ms-choice-border-hover-color: #7f7f7f;
125123
--ms-choice-focus-border-color: #{color.adjust($ms-primary-color, $lightness: 5%)};
126124
--ms-choice-focus-box-shadow: 0 0 0 2px #{rgba($ms-primary-color,.2)};
127125
--ms-drop-background: #2a2f34;

packages/multiple-select-vanilla/src/styles/multiple-select.scss

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,6 @@
110110
text-decoration: none;
111111
user-select: none;
112112
white-space: nowrap;
113-
&:hover {
114-
border-color: var(--ms-choice-border-hover-color, v.$ms-choice-border-hover-color);
115-
}
116113
&:focus {
117114
border-color: var(--ms-choice-focus-border-color, v.$ms-choice-focus-border-color);
118115
box-shadow: var(--ms-choice-focus-box-shadow, v.$ms-choice-focus-box-shadow);

0 commit comments

Comments
 (0)