perf: use .some() instead of .filter() for testing filter length (#411)

ghiscoding · web-flow · commit d24b0112a916 · 2025-07-25T00:59:48.000-04:00
diff --git a/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts b/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts
@@ -1588,7 +1588,7 @@ export class MultipleSelectInstance {
       }
     }
 
-    const noResult = this.data?.filter(row => row.visible).length === 0;
+    const noResult = !this.data?.some(row => row.visible);
 
     if (this.selectAllElm) {
       this.selectAllElm.ariaChecked = String(this.isAllSelected);
@@ -1882,7 +1882,7 @@ export class MultipleSelectInstance {
               });
             }
           }
-          row.visible = (row as OptGroupRowData).children.filter((child: any) => child?.visible).length > 0;
+          row.visible = (row as OptGroupRowData).children.some((child: any) => child?.visible);
         }
       } else {
         const rowText = `${(row as OptionRowData)?.text ?? ''}`;

Original file line number	Diff line number	Diff line change
`@@ -1588,7 +1588,7 @@ export class MultipleSelectInstance {`
`1588`	`1588`	`}`
`1589`	`1589`	`}`
`1590`	`1590`
`1591`		`- const noResult = this.data?.filter(row => row.visible).length === 0;`
	`1591`	`+ const noResult = !this.data?.some(row => row.visible);`
`1592`	`1592`
`1593`	`1593`	`if (this.selectAllElm) {`
`1594`	`1594`	`this.selectAllElm.ariaChecked = String(this.isAllSelected);`
`@@ -1882,7 +1882,7 @@ export class MultipleSelectInstance {`
`1882`	`1882`	`});`
`1883`	`1883`	`}`
`1884`	`1884`	`}`
`1885`		`- row.visible = (row as OptGroupRowData).children.filter((child: any) => child?.visible).length > 0;`
	`1885`	`+ row.visible = (row as OptGroupRowData).children.some((child: any) => child?.visible);`
`1886`	`1886`	`}`
`1887`	`1887`	`} else {`
`1888`	`1888`	const rowText = `${(row as OptionRowData)?.text ?? ''}`;