fix: consider virtualScroll option to really disable Virtual Scroll
#438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
egor-khanko
changed the title
virtualScroll option when setting up Multiple SelectvirtualScroll option when setting up Multiple Select
egor-khanko
changed the title
virtualScroll option when setting up Multiple SelectvirtualScroll option when setting up multiple select
ghiscoding
changed the title
virtualScroll option when setting up multiple selectvirtualScroll option to really disable Virtual Scroll
Owner
|
oh good catch, thanks a lot :) ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for a nice library!
Documentation states that it's possible to disable virtual scroll with
virtualScroll: falsein MS instance.When I tried to use
virtualScroll: falseto mitigate issue with virtual scroll, it didn't change multiple select behaviour. Last version it worked was v3.0.0I've re-added check for
virtualScrolloption that was removed here: v3.0.0...v3.1.0#diff-98fa1c735f911481424d25b4bd48d504abb02519365960551d3dc2e0a08631ecR463