Skip to content

Commit 50d7a7b

Browse files
committed
chore: rename className to pluginName
1 parent 9983453 commit 50d7a7b

File tree

45 files changed

+85
-62
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+85
-62
lines changed

frameworks-plugins/angular-row-detail-plugin/src/angularSlickRowDetailView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export interface CreatedView {
3131
}
3232

3333
export class AngularSlickRowDetailView extends UniversalSlickRowDetailView {
34-
static pluginName = 'AngularSlickRowDetailView';
34+
static readonly pluginName = 'AngularSlickRowDetailView';
3535
rowDetailContainer!: ViewContainerRef;
3636
protected _preloadComponent: Type<object> | undefined;
3737
protected _preloadCompRef?: ComponentRef<any>;

frameworks-plugins/aurelia-row-detail-plugin/src/aureliaSlickRowDetailView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const PRELOAD_CONTAINER_PREFIX = 'container_loading';
2222

2323
@transient()
2424
export class AureliaSlickRowDetailView extends UniversalSlickRowDetailView {
25-
static pluginName = 'AureliaSlickRowDetailView';
25+
static readonly pluginName = 'AureliaSlickRowDetailView';
2626
protected _preloadViewModel?: Constructable;
2727
protected _preloadController?: ICustomElementController;
2828
protected _slots: CreatedView[] = [];

frameworks-plugins/react-row-detail-plugin/src/reactSlickRowDetailView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export interface CreatedView {
2727
}
2828

2929
export class ReactSlickRowDetailView extends UniversalSlickRowDetailView {
30-
static pluginName = 'ReactSlickRowDetailView';
30+
static readonly pluginName = 'ReactSlickRowDetailView';
3131
protected _component?: any;
3232
protected _preloadComponent?: any;
3333
protected _preloadRoot?: Root;

frameworks-plugins/vue-row-detail-plugin/src/vueSlickRowDetailView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export interface CreatedView {
2929
}
3030

3131
export class VueSlickRowDetailView extends UniversalSlickRowDetailView {
32-
static pluginName = 'VueSlickRowDetailView';
32+
static readonly pluginName = 'VueSlickRowDetailView';
3333
protected _component?: any;
3434
protected _preloadComponent?: any;
3535
protected _preloadApp?: App<Element>;

frameworks/angular-slickgrid/src/library/components/__tests__/angular-slickgrid.component.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const angularUtilServiceStub = {
7171
} as unknown as AngularUtilService;
7272

7373
class AngularSlickRowDetailView {
74-
static pluginName = 'AngularSlickRowDetailView';
74+
static readonly pluginName = 'AngularSlickRowDetailView';
7575
create = vi.fn();
7676
init = vi.fn();
7777
}
@@ -399,7 +399,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
399399
)
400400
);
401401

402-
component.gridId = 'grid1';
402+
(component as any).gridId = 'grid1';
403403
component.columns = [{ id: 'name', field: 'name' }];
404404
component.dataset = [];
405405
component.options = { enableExcelExport: false, dataView: null } as unknown as GridOption;
@@ -1783,7 +1783,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
17831783
component.columns = mockCols;
17841784
component.options = {
17851785
...gridOptions,
1786-
enableRowDetailView: true,
1786+
// enableRowDetailView: true,
17871787
externalResources: [AngularSlickRowDetailView],
17881788
presets: { columns: mockColsPresets },
17891789
} as GridOption;

frameworks/angular-slickgrid/src/library/components/angular-slickgrid.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ const WARN_NO_PREPARSE_DATE_SIZE = 10000; // data size to warn user when pre-par
7979

8080
export interface AngularSlickRowDetailView {
8181
create(columns: Column[], gridOptions: GridOption): any;
82-
init(grid: SlickGrid): void;
82+
init(grid: SlickGrid, containerService?: ContainerService): void;
8383
}
8484

8585
@Component({
@@ -1619,14 +1619,14 @@ export class AngularSlickgridComponent<TData = any> implements AfterViewInit, On
16191619
}
16201620

16211621
/** initialized & auto-enable external registered resources, e.g. if user registers `ExcelExportService` then let's auto-enable `enableExcelExport:true` */
1622-
protected autoEnableInitializedResources(resource: ExternalResource): void {
1622+
protected autoEnableInitializedResources(resource: ExternalResource | ExternalResourceConstructor): void {
16231623
if (this.slickGrid && typeof (resource as ExternalResource).init === 'function') {
16241624
(resource as ExternalResource).init!(this.slickGrid, this.containerService);
16251625
}
16261626

16271627
// auto-enable unless the flag was specifically disabled by the end user
1628-
if ('className' in (resource as ExternalResource)) {
1629-
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).className!);
1628+
if ('pluginName' in (resource as ExternalResource)) {
1629+
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).pluginName!);
16301630
if (pluginFlagName && this.options[pluginFlagName] !== false) {
16311631
this.options[pluginFlagName] = true;
16321632
this.slickGrid?.setOptions({ [pluginFlagName]: true });

frameworks/angular-slickgrid/test/rxjsResourceStub.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
import { takeUntil } from 'rxjs/operators';
1616

1717
export class RxJsResourceStub implements RxJsFacade {
18-
readonly className = 'RxJsResource';
18+
readonly pluginName = 'RxJsResource';
1919

2020
/**
2121
* The same Observable instance returned by any call to without a scheduler.

frameworks/aurelia-slickgrid/src/custom-elements/aurelia-slickgrid.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const WARN_NO_PREPARSE_DATE_SIZE = 10000; // data size to warn user when pre-par
6262

6363
export interface AureliaSlickRowDetailView {
6464
create(columns: Column[], gridOptions: GridOption): any;
65-
init(grid: SlickGrid): void;
65+
init(grid: SlickGrid, containerService?: ContainerService): void;
6666
}
6767

6868
@customElement({
@@ -1481,14 +1481,14 @@ export class AureliaSlickgridCustomElement {
14811481
}
14821482

14831483
/** initialized & auto-enable external registered resources, e.g. if user registers `ExcelExportService` then let's auto-enable `enableExcelExport:true` */
1484-
protected autoEnableInitializedResources(resource: ExternalResource): void {
1484+
protected autoEnableInitializedResources(resource: ExternalResource | ExternalResourceConstructor): void {
14851485
if (this.grid && typeof (resource as ExternalResource).init === 'function') {
14861486
(resource as ExternalResource).init!(this.grid, this.containerService);
14871487
}
14881488

14891489
// auto-enable unless the flag was specifically disabled by the end user
1490-
if ('className' in (resource as ExternalResource)) {
1491-
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).className!);
1490+
if ('pluginName' in (resource as ExternalResource)) {
1491+
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).pluginName!);
14921492
if (pluginFlagName && this.options[pluginFlagName] !== false) {
14931493
this.options[pluginFlagName] = true;
14941494
this.grid?.setOptions({ [pluginFlagName]: true });
@@ -1514,7 +1514,7 @@ export class AureliaSlickgridCustomElement {
15141514
// register all services by executing their init method and providing them with the Grid object
15151515
if (Array.isArray(this._registeredResources)) {
15161516
for (const resource of this._registeredResources) {
1517-
if ((resource as ExternalResource)?.className === 'RxJsResource') {
1517+
if ((resource as ExternalResource)?.pluginName === 'RxJsResource') {
15181518
this.registerRxJsResource(resource as RxJsFacade);
15191519
}
15201520
}

frameworks/slickgrid-react/src/components/slickgrid-react.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1580,22 +1580,22 @@ export class SlickgridReact<TData = any> extends React.Component<SlickgridReactP
15801580
// register all services by executing their init method and providing them with the Grid object
15811581
if (Array.isArray(this._registeredResources)) {
15821582
for (const resource of this._registeredResources) {
1583-
if ((resource as ExternalResource)?.className === 'RxJsResource') {
1583+
if ((resource as ExternalResource)?.pluginName === 'RxJsResource') {
15841584
this.registerRxJsResource(resource as RxJsFacade);
15851585
}
15861586
}
15871587
}
15881588
}
15891589

15901590
/** initialized & auto-enable external registered resources, e.g. if user registers `ExcelExportService` then let's auto-enable `enableExcelExport:true` */
1591-
protected autoEnableInitializedResources(resource: ExternalResource): void {
1591+
protected autoEnableInitializedResources(resource: ExternalResource | ExternalResourceConstructor): void {
15921592
if (this.grid && typeof (resource as ExternalResource).init === 'function') {
15931593
(resource as ExternalResource).init!(this.grid, this.props.containerService);
15941594
}
15951595

15961596
// auto-enable unless the flag was specifically disabled by the end user
1597-
if ('className' in (resource as ExternalResource)) {
1598-
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).className!);
1597+
if ('pluginName' in (resource as ExternalResource)) {
1598+
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).pluginName!);
15991599
if (pluginFlagName && this.options[pluginFlagName] !== false) {
16001600
this.options[pluginFlagName] = true;
16011601
this.grid?.setOptions({ [pluginFlagName]: true });

frameworks/slickgrid-vue/src/components/SlickgridVue.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const WARN_NO_PREPARSE_DATE_SIZE = 10000; // data size to warn user when pre-par
7373
7474
export interface VueSlickRowDetailView {
7575
create(columns: Column[], gridOptions: GridOption): any;
76-
init(grid: SlickGrid): void;
76+
init(grid: SlickGrid, containerService?: ContainerService): void;
7777
}
7878
7979
const attrs = useAttrs();
@@ -1438,14 +1438,14 @@ function mergeGridOptions(gridOptions: GridOption): GridOption {
14381438
}
14391439
14401440
/** initialized & auto-enable external registered resources, e.g. if user registers `ExcelExportService` then let's auto-enable `enableExcelExport:true` */
1441-
function autoEnableInitializedResources(resource: ExternalResource): void {
1441+
function autoEnableInitializedResources(resource: ExternalResource | ExternalResourceConstructor): void {
14421442
if (grid && typeof (resource as ExternalResource).init === 'function') {
14431443
(resource as ExternalResource).init!(grid, containerService);
14441444
}
14451445
14461446
// auto-enable unless the flag was specifically disabled by the end user
1447-
if ('className' in (resource as ExternalResource)) {
1448-
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).className!);
1447+
if ('pluginName' in (resource as ExternalResource)) {
1448+
const pluginFlagName = PluginFlagMappings.get((resource as ExternalResource).pluginName!);
14491449
if (pluginFlagName && _gridOptions.value[pluginFlagName] !== false) {
14501450
_gridOptions.value[pluginFlagName] = true;
14511451
grid?.setOptions({ [pluginFlagName]: true });
@@ -1471,7 +1471,7 @@ function preRegisterResources() {
14711471
// register all services by executing their init method and providing them with the Grid object
14721472
if (Array.isArray(registeredResources)) {
14731473
for (const resource of registeredResources) {
1474-
if ((resource as ExternalResource)?.className === 'RxJsResource') {
1474+
if ((resource as ExternalResource)?.pluginName === 'RxJsResource') {
14751475
registerRxJsResource(resource as RxJsFacade);
14761476
}
14771477
}

0 commit comments

Comments
 (0)