Support CellSelectionModel in Composite Editor Component

[wscherphof]

Currently, this line in the hasRowSelectionEnabled() function:

slickgrid-universal/packages/composite-editor-component/src/slick-composite-editor.component.ts

Line 1008 in a4a481c

const isRowSelectionEnabled = this.gridOptions.enableRowSelection || this.gridOptions.enableCheckboxSelector;

effectively requires to use the RowSelectionModel in your Grid for the Composite Editor Component to work.

I'm using the CellSelectionModel (and want to keep using it), and managed to get the Composite Editor to work by setting { enableRowSelection: true } just before calling openDetails().

Would it be an idea to loosen the constraints in hasRowSelectionEnabled() function?

[ghiscoding]

Without looking at the code, I think that the main reasons it is required is because of

1. Update Selected rows
2. Edit current row

So the question is what have you tried with your bypass? The Update Selected surely wouldn't work without Row Selection Model, maybe the Update All would be ok and I'm not entirely sure about Edit Current Row. So I wonder what you tried so far?

[ghiscoding]

wow ok I didn't think that use case which is quite unconventional and seems less user friendly, but ok we can probably tweak the condition to have 1 of either RowSelectionModel or CellSelectionModel and that should fix this problem.

[wscherphof]

Then in the case of CellSelectionModel it would be cool to restore the selected ranges, which I currently do manually after the edit (and for which I'm missing an onClose-like event that fires on Cancel when there aren't any changes).

[ghiscoding]

I'm not exactly sure what you mean, you can provide the code maybe (or even better would be a Pull Request), that might be better to keep that logic in the userland (your code). There's already an onClose callback (didn't check the docs though)

slickgrid-universal/packages/composite-editor-component/src/slick-composite-editor.component.ts

Lines 589 to 594 in 44a7420

	/** Cancel the Editing which will also close the modal window */
	async cancelEditing(): Promise<void> {
	let confirmed = true;
	if (this.formValues && Object.keys(this.formValues).length > 0 && typeof this._options.onClose === 'function') {
	confirmed = await this._options.onClose();
	}

[wscherphof]

I'll try a PR.

[wscherphof]

PR is #1990