I guess the changes in `BCEA` have broken this, right?...

[giabaio]

Hi @andbe and @n8thangreen. I was working on this to integrate with the BCEA book, but I guess some of the changes to BCEA have broken (badly) this too? Will the fixes put everything into place, or do we need to worry more specifically about this?...

[n8thangreen]

Hi, I'd updated BCEAweb for the changes in BCEA here
https://github.com/n8thangreen/BCEAweb

which version/repo is it you're working off atm?

[giabaio]

Thanks, @n8thangreen. Not sure it works, though? I have installed your version and tried to run the example importing the spreadsheets (vaccine_parameters.csv and vaccine_results.csv, which are available in the main BCEAweb repo), but they break on several parts...
I get a weird set of errors

Warning: Error in contour2: could not find function "contour2"
  183: withCallingHandlers
  182: suppressMessages
  178: renderPlot [/home/gianluca/R/x86_64-pc-linux-gnu-library/4.4/BCEAweb/BCEAweb/server.R#412]
...

(and similar things for other missing BCEA plots... I think we should probably check it more carefully? Can I fork your branch into the main repo? Or should you push that there?

[n8thangreen]

Hi, it seems to work fine for me 🤔

I'm just running this from R

# test script

data(Vaccine)

BCEAweb(e, c, parameters = vaccine_mat)

# or
BCEAweb:::launch(e, c, parameters = NULL)

vaccine_parameters.csv is called vaccine_mat in BCEA but its exactly the same. I also tried loading those two files in via the GUI as Spreadsheet data and this looks ok too.

Its obviously a bit harder to debug in shiny so perhaps you could show me how it breaks?

[giabaio]

Mmm... not sure. I'll try again from my office computer and see if that makes a difference (but I don't think so...). Perhaps we can meet up and I can share my screen as I do it?

[giabaio]

Same error, actually. Here's what I've done

remotes::install_github("n8thangreen/BCEAweb")
library(BCEAweb)
BCEAweb::BCEAweb()

This launches the web-app. From there, in the Parameter simulation tab, I import the spreadsheet vaccine_parameters.csv, which works OK and produces the histograms. Then I move to the tab Economic analysis and import the vaccine_results.csv spreadsheet. This works OK, but when I click on Run the analysis the underlying R workspace says

> BCEAweb::BCEAweb()
Loading required package: shiny
Warning: Error in bcea: could not find function "bcea"
  165: eventReactiveValueFunc [/usr/local/lib/R/site-library/BCEAweb/BCEAweb/server.R#322]
  113: m
  106: renderPrint [/usr/local/lib/R/site-library/BCEAweb/BCEAweb/server.R#385]
  105: func
   89: renderFunc
   88: output$analysis
    3: shiny::runApp
    2: launch
    1: BCEAweb::BCEAweb

which is actually bizarre... Is it possible we've accidentally removed the dependence on BCEA and so it can't find the relevant files?...

[giabaio]

OK --- actually, I've cloned your branch into my original repo and using that does work... Weird! Do you think that's finalised, @n8thangreen and can I push the changes to this "dev" branch on the main BCEAweb repo (which will update the R-universe package too)?