Merge pull request #29 from gianchub/fix-is-match

Fix is match

Author: gianchub

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [1.0.4]
+
+18/11/2025
+
+- Fix `CompareResult.is_match` property.
+- Fix typo in `dictdiff` method.
+- Remove redundant return statement.
+
 ## [1.0.3]
 
 15/11/2025

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "sqlalchemy-diff"
-version = "1.0.3"
+version = "1.0.4"
 authors = [
     { name = "Fabrizio Romano", email = "[email protected]" },
     { name = "Mark McArdle", email = "[email protected]" },

src/sqlalchemydiff/comparer.py

@@ -57,7 +57,7 @@ def _compile_errors(self) -> dict:
     @property
     def is_match(self):
         """Tell if comparison was a match."""
-        return not self.errors
+        return not any(self.errors.values())
 
     def dump_result(self, filename):
         """Dump `result` dict to a file."""
@@ -157,4 +157,3 @@ def _get_db_info(
             return inspector.inspect(engine, ignore_specs)
         except InspectorNotSupported as e:
             logger.warning({"engine": engine, "inspector": inspector.key, "error": e.message})
-            return None

src/sqlalchemydiff/inspection/mixins.py

@@ -91,7 +91,7 @@ def _itemsdiff(self, items_in_one: Iterable[Mapping], items_in_two: Iterable[Map
         They will be different according to which inspector is being used, but their structure
         will always be consistent, like in the following example:
 
-        one = [
+        items_in_one = [
             {
                 "name": "id",
                 "type": "INTEGER",

tests/test_comparer.py

@@ -37,6 +37,18 @@ def test_compare_result(self):
         assert compare_result.errors == {}
         assert compare_result.is_match
 
+    @pytest.mark.usefixtures("setup_db_one", "setup_db_two")
+    def test_compare_not_match(self, db_engine_one, db_engine_two):
+        comparer = Comparer(db_engine_one, db_engine_two)
+        result = comparer.compare()
+        assert not result.is_match
+
+    @pytest.mark.usefixtures("setup_db_one")
+    def test_compare_is_match(self, db_engine_one):
+        comparer = Comparer(db_engine_one, db_engine_one)
+        result = comparer.compare()
+        assert result.is_match
+
 
 class TestComparer(BaseTest):
     @pytest.fixture