Merge pull request kunalkapadia#372 from KunalKapadia/develop

limit cast fix and remove port from mongoUri

Author: kunalkapadia

index.js

@@ -14,7 +14,7 @@ Promise = require('bluebird'); // eslint-disable-line no-global-assign
 mongoose.Promise = Promise;
 
 // connect to mongo db
-const mongoUri = `${config.mongo.host}:${config.mongo.port}`;
+const mongoUri = config.mongo.host;
 mongoose.connect(mongoUri, { server: { socketOptions: { keepAlive: 1 } } });
 mongoose.connection.on('error', () => {
   throw new Error(`unable to connect to database: ${config.db}`);

package.json

@@ -73,7 +73,7 @@
     "cross-env": "3.1.3",
     "cz-conventional-changelog": "1.2.0",
     "del": "^2.2.0",
-    "eslint": "3.16.0",
+    "eslint": "3.16.1",
     "eslint-config-airbnb-base": "7.1.0",
     "eslint-plugin-import": "1.16.0",
     "eslint-watch": "2.1.14",

server/models/user.model.js

@@ -65,8 +65,8 @@ UserSchema.statics = {
   list({ skip = 0, limit = 50 } = {}) {
     return this.find()
       .sort({ createdAt: -1 })
-      .skip(skip)
-      .limit(limit)
+      .skip(+skip)
+      .limit(+limit)
       .exec();
   }
 };

server/tests/user.test.js

@@ -91,6 +91,18 @@ describe('## User APIs', () => {
         })
         .catch(done);
     });
+
+    it('should get all users (with limit and skip)', (done) => {
+      request(app)
+        .get('/api/users')
+        .query({ limit: 10, skip: 1 })
+        .expect(httpStatus.OK)
+        .then((res) => {
+          expect(res.body).to.be.an('array');
+          done();
+        })
+        .catch(done);
+    });
   });
 
   describe('# DELETE /api/users/', () => {