Fix zone caching (#300)

robinkb · web-flow · commit bec5b0e2f540 · 2025-10-02T10:33:33.000+02:00
* Fix zone caching

* Update CHANGELOG
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix caching of Route 53 zones
+
 ## [0.23.0] - 2025-10-01
 
 ### Changed
diff --git a/pkg/aws/route53.go b/pkg/aws/route53.go
@@ -280,7 +280,7 @@ func (r *Route53) GetHostedZoneIdByName(ctx context.Context, logger logr.Logger,
 	// If the response was considered fully valid above, cache all returned zones
 	for _, hostedZone := range listResponse.HostedZones {
 		cacheKey := strings.TrimSuffix(*hostedZone.Name, ".")
-		r.zoneNameToIdCache.SetDefault(cacheKey, foundZoneId)
+		r.zoneNameToIdCache.SetDefault(cacheKey, sanitizeZoneId(*hostedZone.Id))
 	}
 
 	if foundZoneId == "" {

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ func (r *Route53) GetHostedZoneIdByName(ctx context.Context, logger logr.Logger,`
`280`	`280`	`// If the response was considered fully valid above, cache all returned zones`
`281`	`281`	`for _, hostedZone := range listResponse.HostedZones {`
`282`	`282`	`cacheKey := strings.TrimSuffix(*hostedZone.Name, ".")`
`283`		`- r.zoneNameToIdCache.SetDefault(cacheKey, foundZoneId)`
	`283`	`+ r.zoneNameToIdCache.SetDefault(cacheKey, sanitizeZoneId(*hostedZone.Id))`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`if foundZoneId == "" {`