Add Crossplane IAM roles, policies, and instance profiles for worker nodes #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note As this is a draft PR no triggers from the PR body will be handled. If you'd like to trigger them while draft please add them as a PR comment. |
fiunchinho
force-pushed
the
iam-workers-crossplane
branch
from
ab253d4 to
f9ace2f
Compare
|
/run cluster-test-suites |
cluster-test-suites
❌ Failed test suitesCAPA Standard Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard |
cluster-test-suites
❌ Failed test suitesCAPA Standard Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard |
cluster-test-suites
❌ Failed test suitesCAPA Standard Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
fiunchinho
force-pushed
the
iam-workers-crossplane
branch
from
f9ace2f to
09a5a37
Compare
fiunchinho
force-pushed
the
iam-workers-crossplane
branch
from
09a5a37 to
07973eb
Compare
fiunchinho
force-pushed
the
iam-workers-crossplane
branch
2 times, most recently
from
bfb1249 to
a56addb
Compare
fiunchinho
force-pushed
the
iam-workers-crossplane
branch
from
a56addb to
2e07c33
Compare
|
There were differences in the rendered Helm template, please check! Output |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china |
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/ |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/china |
cluster-test-suites
✅ Passed test suitesCAPA China Suite ✅
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
cluster-test-suites
✅ Passed test suitesCAPA Cilium ENI Mode Suite ✅
CAPA Private Suite ✅
CAPA Standard Suite ✅
❌ Failed test suitesCAPA China Suite ❌
CAPA Karpenter Suite ❌
CAPA Upgrade Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/china,./providers/capa/karpenter |
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/karpenter,./providers/capa/china |
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/karpenter |
1 similar comment
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/karpenter |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/china |
cluster-test-suites
✅ Passed test suitesCAPA China Suite ✅
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
/run cluster-test-suites TARGET_SUITES=./providers/capa/karpenter |
cluster-test-suites
❌ Failed test suitesCAPA Karpenter Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
|
Oh No! 😱 At least one test suite has failed during the Be sure to check the full results in Tekton Dashboard to see which test suite has failed and then run the following on the associated MC to list all leftover resources: PIPELINE_RUN="pr-cluster-aws-1555-cluster-test-suitesd69sb"
NAMES="$(kubectl api-resources --verbs list -o name | tr '\n' ,)"
kubectl get "${NAMES:0:${#NAMES}-1}" --show-kind --ignore-not-found -l cicd.giantswarm.io/pipelinerun=${PIPELINE_RUN} -A 2>/dev/null |
cluster-test-suites
❌ Failed test suitesCAPA Karpenter Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
cluster-test-suites
❌ Failed test suitesCAPA Karpenter Suite ❌
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a
Available Test SuitesBy default, only the standard test suite runs to reduce costs. If your changes affect specialized environments, you can specify additional test suites: AWS (CAPA) Test Suites
How to Specify Additional Test Suites# Run specific test suites
/run cluster-test-suites TARGET_SUITES=./providers/capa/standard,./providers/capa/china
# Run all test suites for CAPA
/run cluster-test-suites TARGET_SUITES=./providers/capa/
# Run upgrade tests
/run cluster-test-suites TARGET_SUITES=./providers/capa/upgrade,./providers/capa/upgrade-majorNote: Full test suites run automatically on releases. You are responsible for testing all relevant flavors before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Towards https://github.com/giantswarm/giantswarm/issues/34549
This change will roll nodes, because we are changing the instance profile for the control plane instances, and the node pool ASGs (CAPA) / EC2 instances (karpenter).
In this PR we are changing
capa-iam-operatorto skip creating the IAM Roles for the workers and the control plane nodes, when the cluster is using GiantSwarm Release v34 or above. We plan to release the changes in this PR with that Release v34.Once clusters are using v35, we can remove the old IAM Roles, policies and instance profiles that were created by
capa-iam-operator.Checklist
Trigger E2E tests
/run cluster-test-suites