Skip to content

Commit 8908dbb

Browse files
committed
Fix some iterate TODO's in layout pass
1 parent 6e0d395 commit 8908dbb

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

gibbon-compiler/src/Gibbon/Passes/AccessPatternsAnalysis.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ getGreedyOrder edges fieldLength =
8484
completeOrder = P.foldl (\lst val -> if S.member val (S.fromList lst) then lst
8585
else lst ++ [val]
8686
) partial_order [0 .. (fieldLength - 1)]
87-
in dbgTraceIt (sdoc (edges, completeOrder)) P.map P.toInteger completeOrder
87+
in P.map P.toInteger completeOrder --dbgTraceIt (sdoc (edges, completeOrder)) P.map P.toInteger completeOrder
8888

8989
greedyOrderOfVertices :: [((Integer, Integer), Integer)] -> [Int]
9090
greedyOrderOfVertices ee = let edges' = P.map (\((a, b), c) -> ((P.fromIntegral a, P.fromIntegral b), P.fromIntegral c)) ee
@@ -244,7 +244,7 @@ freeVarsInOrder exp =
244244
var_list = L.concat var_list_list
245245
in var_list
246246
ProjE i e -> error "freeVarsInOrder: TODO ProjE"
247-
TimeIt e ty b -> error "freeVarsInOrder: TODO TimeIt"
247+
TimeIt e ty b -> freeVarsInOrder e
248248
WithArenaE v e -> error "freeVarsInOrder: TODO WithArenaE"
249249
SpawnE f locs args -> error "freeVarsInOrder: TODO SpawnE"
250250
SyncE -> error "freeVarsInOrder: TODO SyncE"

gibbon-compiler/src/Gibbon/Passes/OptimizeADTLayout.hs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ dataConsInFunBody funBody = case funBody of
165165
IfE a b c -> S.unions $ [dataConsInFunBody a] ++ [dataConsInFunBody b] ++ [dataConsInFunBody c]
166166
MkProdE xs -> S.unions $ P.map dataConsInFunBody xs
167167
ProjE i e -> error "getGeneratedVariable: TODO ProjE"
168-
TimeIt e ty b -> error "getGeneratedVariable: TODO TimeIt"
168+
TimeIt e ty b -> dataConsInFunBody e
169169
WithArenaE v e -> error "getGeneratedVariable: TODO WithArenaE"
170170
SpawnE f locs args -> error "getGeneratedVariable: TODO SpawnE"
171171
SyncE -> error "getGeneratedVariable: TODO SyncE"
@@ -611,7 +611,7 @@ changeCallNameInRecFunction
611611
IfE a b c -> IfE (fixExp a) (fixExp b) (fixExp c)
612612
MkProdE xs -> MkProdE (P.map fixExp xs)
613613
ProjE i e -> error "getExpTyEnv: TODO ProjE"
614-
TimeIt e ty b -> error "getExpTyEnv: TODO TimeIt"
614+
TimeIt e ty b -> TimeIt (fixExp e) ty b
615615
WithArenaE v e -> error "getExpTyEnv: TODO WithArenaE"
616616
SpawnE f locs args -> error "getExpTyEnv: TODO SpawnE"
617617
SyncE -> error "getExpTyEnv: TODO SyncE"
@@ -1497,7 +1497,8 @@ reOrderLetExpHelper (Just var) letExpOrder expr = fst $ run letExpOrder expr
14971497
MkProdE xs -> let (xs', releasedBinds) = lambdaHandleExpList xs letExpOrder'
14981498
in (MkProdE xs', releasedBinds)
14991499
ProjE {} -> error "reOrderLetExpHelper: TODO ProjE"
1500-
TimeIt {} -> error "reOrderLetExpHelper: TODO TimeIt"
1500+
TimeIt e ty b -> let (e', releasedBinds) = run letExpOrder' e
1501+
in (TimeIt e' ty b, releasedBinds)
15011502
WithArenaE {} -> error "reOrderLetExpHelper: TODO WithArenaE"
15021503
SpawnE {} -> error "reOrderLetExpHelper: TODO SpawnE"
15031504
SyncE -> error "reOrderLetExpHelper: TODO SyncE"

0 commit comments

Comments
 (0)