Update how release health is determined (#17)

* Prefer Number() to parseInt(). Resolves #7

* Fix issue where action stalls for apps using >1 replica. Fixes #12

* Bump version to 0.4.0, update changelog

* Update CHANGELOG.md per PR suggestion

Co-authored-by: Mitchell Hanberg <mitch@mitchellhanberg.com>

Co-authored-by: Mitchell Hanberg <mitch@mitchellhanberg.com>

Author: ltk

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## v0.4.0
+
+- Fixed an issue where the action would get stuck at 'Getting current replicas' for apps requesting more than one replica
+- Does a health check every 10 seconds instead of increasing the wait time exponentially. Times out now after 10 minutes.
+
 ## v0.3.0
 
 - Only add private key and wait for deploy if we are migrating [(#9)](https://github.com/mhanberg/gigalixir-action/pull/9)

dist/index.js

@@ -975,20 +975,20 @@ async function isNextReleaseHealthy(release, app) {
     await exec.exec(`gigalixir ps -a ${app}`, [], options);
   });
 
-  const pods = JSON.parse(releasesOutput).pods;
-  const pod = pods[0];
-
-  return pods.length === 1 && parseInt(pod.version) === release && pod.status === "Healthy";
+  const releases = JSON.parse(releasesOutput);
+  const pods = releases.pods;
+  return releases.pods.filter((pod) => (Number(pod.version) === release && pod.status === "Healthy")).length >= releases.replicas_desired;
 }
 
-async function waitForNewRelease(oldRelease, app, multiplier) {
+async function waitForNewRelease(oldRelease, app, attempts) {
+  const maxAttempts = 60;
+
   if (await isNextReleaseHealthy(oldRelease + 1, app)) {
     return await Promise.resolve(true);
   } else {
-    if (multiplier <= 10) {
-      await wait(Math.pow(2, multiplier));
-
-      await waitForNewRelease(oldRelease, app, multiplier + 1);
+    if (attempts <= maxAttempts) {
+      await wait(10);
+      await waitForNewRelease(oldRelease, app, attempts + 1);
     } else {
       throw "Taking too long for new release to deploy";
     }
@@ -1010,7 +1010,7 @@ async function getCurrentRelease(app) {
     await exec.exec(`gigalixir releases -a ${app}`, [], options);
   });
 
-  const currentRelease = parseInt(JSON.parse(releasesOutput)[0].version);
+  const currentRelease = Number(JSON.parse(releasesOutput)[0].version);
 
   return currentRelease;
 }

index.js

@@ -29,20 +29,20 @@ async function isNextReleaseHealthy(release, app) {
     await exec.exec(`gigalixir ps -a ${app}`, [], options);
   });
 
-  const pods = JSON.parse(releasesOutput).pods;
-  const pod = pods[0];
-
-  return pods.length === 1 && parseInt(pod.version) === release && pod.status === "Healthy";
+  const releases = JSON.parse(releasesOutput);
+  const pods = releases.pods;
+  return releases.pods.filter((pod) => (Number(pod.version) === release && pod.status === "Healthy")).length >= releases.replicas_desired;
 }
 
-async function waitForNewRelease(oldRelease, app, multiplier) {
+async function waitForNewRelease(oldRelease, app, attempts) {
+  const maxAttempts = 60;
+
   if (await isNextReleaseHealthy(oldRelease + 1, app)) {
     return await Promise.resolve(true);
   } else {
-    if (multiplier <= 10) {
-      await wait(Math.pow(2, multiplier));
-
-      await waitForNewRelease(oldRelease, app, multiplier + 1);
+    if (attempts <= maxAttempts) {
+      await wait(10);
+      await waitForNewRelease(oldRelease, app, attempts + 1);
     } else {
       throw "Taking too long for new release to deploy";
     }
@@ -64,7 +64,7 @@ async function getCurrentRelease(app) {
     await exec.exec(`gigalixir releases -a ${app}`, [], options);
   });
 
-  const currentRelease = parseInt(JSON.parse(releasesOutput)[0].version);
+  const currentRelease = Number(JSON.parse(releasesOutput)[0].version);
 
   return currentRelease;
 }

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "gigalixir-action",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "Action to deploy to gigalixir",
   "main": "index.js",
   "scripts": {