fix: resolve clause ordering, moduledoc, and test issues

- Move :directive atom clauses before generic clauses in coordinate_for/2
  and coordinate_for/3 to prevent shadowing by pattern match order
- Escape string interpolation in @moduledoc to prevent compile-time eval
- Fix coordinate resolution tests to use "RootQueryType" (Absinthe's
  default query type name) instead of "Query"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jwaldrip

lib/absinthe/schema/coordinate/error_helpers.ex

@@ -10,7 +10,7 @@ defmodule Absinthe.Schema.Coordinate.ErrorHelpers do
       import Absinthe.Schema.Coordinate.ErrorHelpers
 
       # In an error message
-      "Field #{coordinate_for(type, field)} is deprecated"
+      "Field \#{coordinate_for(type, field)} is deprecated"
 
       # Adding coordinate to error extras
       error
@@ -46,26 +46,26 @@ defmodule Absinthe.Schema.Coordinate.ErrorHelpers do
     Coordinate.for_type(type_name)
   end
 
-  @spec coordinate_for(String.t(), String.t()) :: String.t()
-  def coordinate_for(type_name, field_name) do
-    Coordinate.for_field(to_string(type_name), to_string(field_name))
-  end
-
   @spec coordinate_for(:directive, String.t()) :: String.t()
   def coordinate_for(:directive, directive_name) do
     Coordinate.for_directive(to_string(directive_name))
   end
 
-  @spec coordinate_for(String.t(), String.t(), String.t()) :: String.t()
-  def coordinate_for(type_name, field_name, arg_name) do
-    Coordinate.for_argument(to_string(type_name), to_string(field_name), to_string(arg_name))
+  @spec coordinate_for(String.t(), String.t()) :: String.t()
+  def coordinate_for(type_name, field_name) do
+    Coordinate.for_field(to_string(type_name), to_string(field_name))
   end
 
   @spec coordinate_for(:directive, String.t(), String.t()) :: String.t()
   def coordinate_for(:directive, directive_name, arg_name) do
     Coordinate.for_directive_argument(to_string(directive_name), to_string(arg_name))
   end
 
+  @spec coordinate_for(String.t(), String.t(), String.t()) :: String.t()
+  def coordinate_for(type_name, field_name, arg_name) do
+    Coordinate.for_argument(to_string(type_name), to_string(field_name), to_string(arg_name))
+  end
+
   @doc """
   Add a schema coordinate to an error's extra data.
 

test/absinthe/schema/coordinate_test.exs

@@ -152,7 +152,7 @@ defmodule Absinthe.Schema.CoordinateTest do
     end
 
     test "resolve/2 resolves argument coordinates" do
-      assert {:ok, arg} = Coordinate.resolve(TestSchema, "Query.user(id:)")
+      assert {:ok, arg} = Coordinate.resolve(TestSchema, "RootQueryType.user(id:)")
       assert arg.identifier == :id
     end
 
@@ -175,8 +175,8 @@ defmodule Absinthe.Schema.CoordinateTest do
     end
 
     test "resolve/2 returns error for non-existent argument" do
-      assert {:error, "Argument not found: Query.user(nonexistent:)"} =
-               Coordinate.resolve(TestSchema, "Query.user(nonexistent:)")
+      assert {:error, "Argument not found: RootQueryType.user(nonexistent:)"} =
+               Coordinate.resolve(TestSchema, "RootQueryType.user(nonexistent:)")
     end
 
     test "resolve/2 returns error for non-existent directive" do