Fix Double Gzip #71
Open
Fix Double Gzip #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f96485.
vvalkonen
reviewed
Sep 2, 2024
| if len(input) < 2 { | ||
| return false | ||
| } | ||
| return input[0] == 0x1f && input[1] == 0x8b |
There was a problem hiding this comment.
If you look at the func (z *Reader) readHeader() (hdr Header, err error) on compress/gzip/gunzip.go file it should include the deflate option too, hence this should do it:
var gzipHeader = []byte{0x1f, 0x8b, 0x08}
func IsGzip(b []byte) bool {
if len(b) < 3 {
return false
}
return bytes.Equal(b[0:3], gzipHeader)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47 try to fix the double gzip