review updates

- make accessor constexpr
- rename device_view namespace to view

Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>

Author: 3 people

core/test/matrix/device_views.cpp

@@ -18,8 +18,8 @@ TYPED_TEST_SUITE(DenseView, gko::test::ValueTypes, TypenameNameGenerator);
 TYPED_TEST(DenseView, AccessWorks)
 {
     std::vector<TypeParam> values(10);
-    gko::matrix::device_view::dense<TypeParam> view{gko::dim<2>{1, 2}, 3,
-                                                    values.data()};
+    gko::matrix::view::dense<TypeParam> view{gko::dim<2>{1, 2}, 3,
+                                             values.data()};
 
     ASSERT_EQ(view.size, gko::dim<2>(1, 2));
     ASSERT_EQ(view.stride, 3);

include/ginkgo/core/matrix/dense.hpp

@@ -186,8 +186,8 @@ class Dense
     using absolute_type = remove_complex<Dense>;
     using real_type = absolute_type;
     using complex_type = to_complex<Dense>;
-    using device_view = matrix::device_view::dense<value_type>;
-    using const_device_view = matrix::device_view::dense<const value_type>;
+    using device_view = matrix::view::dense<value_type>;
+    using const_device_view = matrix::view::dense<const value_type>;
 
     using row_major_range = gko::range<gko::accessor::row_major<ValueType, 2>>;
 

include/ginkgo/core/matrix/device_views.hpp

@@ -10,11 +10,11 @@
 
 namespace gko {
 namespace matrix {
-namespace device_view {
+namespace view {
 
 
 /**
- * non-owning view of a matrix::Dense to be used inside device kernels.
+ * Non-owning view of a matrix::Dense to be used inside device kernels.
  * This type is used to provide a simple and stable ABI for passing data between
  * libraries.
  *
@@ -26,14 +26,14 @@ struct dense {
     size_type stride;
     ValueType* data;
 
-    ValueType& operator()(size_type row, size_type col) const
+    constexpr ValueType& operator()(size_type row, size_type col) const
     {
         return data[row * stride + col];
     }
 };
 
 
-}  // namespace device_view
+}  // namespace view
 }  // namespace matrix
 }  // namespace gko