Merge relaxed type requirements for stopping criterion parameters

Previously we had to use with_iterations(1u) or with_iterations(static_cast<unsigned>(count)) to avoid build failures with integer iteration counts, now this is turned into conversion warnings only.

Related PR: #1941

Author: upsj

include/ginkgo/core/stop/iteration.hpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
+// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
 //
 // SPDX-License-Identifier: BSD-3-Clause
 
@@ -30,7 +30,13 @@ class Iteration : public EnablePolymorphicObject<Iteration, Criterion> {
         /**
          * Maximum number of iterations
          */
-        size_type GKO_FACTORY_PARAMETER_SCALAR(max_iters, 0);
+        size_type max_iters{0};
+
+        parameters_type& with_max_iters(size_type value)
+        {
+            this->max_iters = value;
+            return *this;
+        }
     };
     GKO_ENABLE_CRITERION_FACTORY(Iteration, parameters, Factory);
     GKO_ENABLE_BUILD_METHOD(Factory);

include/ginkgo/core/stop/residual_norm.hpp

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors
+// SPDX-FileCopyrightText: 2017 - 2025 The Ginkgo authors
 //
 // SPDX-License-Identifier: BSD-3-Clause
 
@@ -7,7 +7,6 @@
 
 
 #include <limits>
-#include <type_traits>
 
 #include <ginkgo/core/base/array.hpp>
 #include <ginkgo/core/base/math.hpp>
@@ -121,9 +120,14 @@ class ResidualNorm : public ResidualNormBase<ValueType> {
         /**
          * Residual norm reduction factor
          */
-        remove_complex<ValueType> GKO_FACTORY_PARAMETER_SCALAR(
-            reduction_factor,
-            5 * std::numeric_limits<remove_complex<ValueType>>::epsilon());
+        remove_complex<ValueType> reduction_factor{
+            5 * std ::numeric_limits<remove_complex<ValueType>>::epsilon()};
+
+        parameters_type& with_reduction_factor(remove_complex<ValueType> value)
+        {
+            this->reduction_factor = value;
+            return *this;
+        }
 
         /**
          * The quantity the reduction is relative to. Choices include
@@ -178,9 +182,14 @@ class ImplicitResidualNorm : public ResidualNormBase<ValueType> {
         /**
          * Implicit Residual norm goal
          */
-        remove_complex<ValueType> GKO_FACTORY_PARAMETER_SCALAR(
-            reduction_factor,
-            5 * std::numeric_limits<remove_complex<ValueType>>::epsilon());
+        remove_complex<ValueType> reduction_factor{
+            5 * std ::numeric_limits<remove_complex<ValueType>>::epsilon()};
+
+        parameters_type& with_reduction_factor(remove_complex<ValueType> value)
+        {
+            this->reduction_factor = value;
+            return *this;
+        }
 
         /**
          * The quantity the reduction is relative to. Choices include
@@ -254,9 +263,14 @@ class GKO_DEPRECATED(
         /**
          * Factor by which the residual norm will be reduced
          */
-        remove_complex<ValueType> GKO_FACTORY_PARAMETER_SCALAR(
-            reduction_factor,
-            5 * std::numeric_limits<remove_complex<ValueType>>::epsilon());
+        remove_complex<ValueType> reduction_factor{
+            5 * std ::numeric_limits<remove_complex<ValueType>>::epsilon()};
+
+        parameters_type& with_reduction_factor(remove_complex<ValueType> value)
+        {
+            this->reduction_factor = value;
+            return *this;
+        }
     };
     GKO_ENABLE_CRITERION_FACTORY(ResidualNormReduction<ValueType>, parameters,
                                  Factory);
@@ -311,9 +325,15 @@ class GKO_DEPRECATED(
         /**
          * Relative residual norm goal
          */
-        remove_complex<ValueType> GKO_FACTORY_PARAMETER_SCALAR(
-            tolerance,
-            5 * std::numeric_limits<remove_complex<ValueType>>::epsilon());
+        remove_complex<ValueType> tolerance{
+            5 * std ::numeric_limits<remove_complex<ValueType>>::epsilon()};
+
+
+        parameters_type& with_tolerance(remove_complex<ValueType> value)
+        {
+            this->tolerance = value;
+            return *this;
+        }
     };
     GKO_ENABLE_CRITERION_FACTORY(RelativeResidualNorm<ValueType>, parameters,
                                  Factory);
@@ -365,9 +385,14 @@ class GKO_DEPRECATED(
         /**
          * Absolute residual norm goal
          */
-        remove_complex<ValueType> GKO_FACTORY_PARAMETER_SCALAR(
-            tolerance,
-            5 * std::numeric_limits<remove_complex<ValueType>>::epsilon());
+        remove_complex<ValueType> tolerance{
+            5 * std ::numeric_limits<remove_complex<ValueType>>::epsilon()};
+
+        parameters_type& with_tolerance(remove_complex<ValueType> value)
+        {
+            this->tolerance = value;
+            return *this;
+        }
     };
     GKO_ENABLE_CRITERION_FACTORY(AbsoluteResidualNorm<ValueType>, parameters,
                                  Factory);