Conversation
yhmtsai
approved these changes
Jan 16, 2026
Collaborator
Author
|
rebased the PR |
gojakuch
added
the
1:ST:no-changelog-entry
Collaborator
Author
|
@yhmtsai if anything, I'm not authorised to merge into the |
Member
|
I have the same issue. I will check the setup |
Member
|
@gojakuch could you check whether the button is available to you? |
Collaborator
Author
|
@yhmtsai no, still not authorised :( |
Member
|
I will go ahead and merge this. |
Collaborator
Author
|
@pratikvn sure, it's up to date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1972, for now we can just increase the tolerance of this test, so that it doesn't fail on the architecture in question, as it had already been noted that PIPECG can have some precision issues.
according to my calculations, replacing
5with6in the multiplier for the tolerance is enough, since:5*(2.008522553101075/1.6852000649168166) = 5.959300011064911where the fraction is taken from the test fail report as the actual error divided by the previous tolerance.
Fixes: #1972