Refactor kernels to use dense device view#1978
Conversation
still some issues (e.g. macro parameter names not matching between levels of expansion)
|
Issues found so far:
|
|
The get_stride replacement was simply missing. Creating the compile_commands.json with clang as the host compiler should fix the missing header issues. I'll try to compile against dpcpp later. Avoiding replacements in header files and member functions should avoid the kernel_launch issues, also we could skip functions that don't have the executor as first parameter (those are kernels) |
|
Maybe it would make sense to add the clang formatting plugin to this PR? That could make it easier to talk about issues with the plugin. We could later decide if the plugin is also distributed in ginkgo (e.g. in the scripts dir) or not. |
|
Not sure I follow, the clang-format step is just a call of |
|
The automated refactoring needed some significant fixes (I'll use this as a running list until I push it)
|
Using https://github.com/upsj/ginkgo-refactor to refactor headers and source files
Still WIP, since some of the replacements were incorrect
Running this requires compiling LLVM with PR llvm/llvm-project#177442
and compiling ginkgo-refactor based on it and then running