Misc. cleanup

Author: raymond-lam

CONTRIBUTING.md

@@ -14,7 +14,7 @@ In this repository, the source code for the component library is in the `src` di
 
 The example app being run on the [GitHub Pages site](https://ginkgobioworks.github.io/react-json-schema-form-builder/), meanwhile, has its code stored in the `example` directory. It relies on an additional set of dependencies, which are stored in the `devDependencies` within the `package.json` file.
 
-Library definitions for [Flow type annotations](https://flow.org/en/docs/types/) are stored in `src/flowlibdefs`, where the file structure under the `flow-typed` [best practices](https://github.com/flow-typed/flow-typed/blob/master/CONTRIBUTING.md) are followed. If any of the types in `src/formBuilder/types.js` are changed, or if the properties of the `FormBuilder` or `PredefinedGallery` are altered, then these flow typed library definitions should also be changed. This library definition is altered manually, and is currently set for major version 1 of the Form Builder. To update to library definition a PR must be made on the [flow-typed repository](https://github.com/flow-typed/flow-typed).
+Library definitions for [Flow type annotations](https://flow.org/en/docs/types/) are stored in `flow-libdef`, where the file structure under the `flow-typed` [best practices](https://github.com/flow-typed/flow-typed/blob/master/CONTRIBUTING.md) are followed. If any of the types in `src/formBuilder/types.js` are changed, or if the properties of the `FormBuilder` or `PredefinedGallery` are altered, then these `flow-typed` library definitions as well as the definitions in the actual `flow-typed` [repository](https://github.com/flow-typed/flow-typed) should also be changed. These library definitions are updated manually, and are currently set for major version 1 of the Form Builder. To update to library definition in the `flow-typed` repository a PR must be made on the [flow-typed repository](https://github.com/flow-typed/flow-typed).
 
 ## Testing
 
@@ -32,4 +32,4 @@ GitHub Pages runs off the `gh-pages` branch, which can only be pushed to by the
 
 ## Release
 
-The maintainers will release new versions to NPM as appropriate. The procedure that the maintainers will use to release is to update the changelog with the newest version, update the package.json version, and tag the main branch with the version number, upon which the travis-CI will run tests again before deploying to NPM automatically.
+The maintainers will release new versions to NPM as appropriate. The procedure that the maintainers will use to release is to update the changelog with the newest version, update the package.json version, and tag the main branch with the version number, upon which the travis-CI will run tests again before deploying to NPM automatically.

src/formBuilder/Section.test.js

@@ -20,8 +20,8 @@ const props = {
   onRequireToggle: () => mockEvent('toggledRequire'),
   onDelete: () => mockEvent('delete'),
   path: 'section',
-  definitionData: '',
-  definitionUi: '',
+  definitionData: {},
+  definitionUi: {},
   allFormInputs: DEFAULT_FORM_INPUTS,
 };
 
@@ -72,10 +72,7 @@ describe('Section', () => {
   it('adds components to the internal schema', () => {
     const div = document.createElement('div');
     document.body.appendChild(div);
-    const wrapper = mount(
-      <Section {...{ ...props, schema: '', uischema: '' }} />,
-      { attachTo: div },
-    );
+    const wrapper = mount(<Section {...props} />, { attachTo: div });
     const plusButton = wrapper.find('.fa-plus-square').first();
     plusButton.simulate('click');
     const createButton = wrapper.find('button').at(1);

src/formBuilder/defaults/arrayInputs.js

@@ -57,7 +57,7 @@ function CardArrayParameterInputs({
   );
 }
 
-function InnerCardWrapper({
+function getInnerCardComponent({
   defaultFormInputs,
 }: {
   defaultFormInputs: { [string]: FormInput },
@@ -170,7 +170,7 @@ defaultFormInputs.array = {
   },
   defaultUiSchema: {},
   type: 'array',
-  cardBody: InnerCardWrapper({ defaultFormInputs }),
+  cardBody: getInnerCardComponent({ defaultFormInputs }),
   modalBody: CardArrayParameterInputs,
 };
 
@@ -187,7 +187,7 @@ const ArrayInputs = {
     },
     defaultUiSchema: {},
     type: 'array',
-    cardBody: InnerCardWrapper({ defaultFormInputs }),
+    cardBody: getInnerCardComponent({ defaultFormInputs }),
     modalBody: CardArrayParameterInputs,
   },
 };