minor optimizations and refactoring

Author: giometrix

README.md

@@ -5,7 +5,7 @@
 
 This project builds on top of [TableStorage.Abstractions](https://github.com/Tazmainiandevil/TableStorage.Abstractions) (a repository wrapper over [Azure Table Storage](https://docs.microsoft.com/en-us/azure/cosmos-db/table-storage-how-to-use-dotnet)) and [TableStorage.Abstractions.TableEntityConverters](https://github.com/giometrix/TableStorage.Abstractions.TableEntityConverters) such that objects to be serialized to and from Azure Table Storage are Plain Old CLR Objects (POCO) rather than TableEntities.
 
-### For secondary index support, check out [TableStorage.Abstractions.POCO.SecondaryIndexes](https://github.com/giometrix/TableStorage.Abstractions.POCO/tree/master/src/TableStorage.Abstractions.POCO.SecondaryIndexes).
+## For secondary index support, check out [TableStorage.Abstractions.POCO.SecondaryIndexes](https://github.com/giometrix/TableStorage.Abstractions.POCO/tree/master/src/TableStorage.Abstractions.POCO.SecondaryIndexes)
 
 ## Examples
 Assume we have the following two classes, which we wish to serialize to and from Azure Table Storage:
@@ -147,7 +147,6 @@ To retrieve the record, we can use ```PartitionKey``` to build the multi-part ke
 var record = tableStore.GetRecord(new PartitionKey(1, 22), 1);
 ```
 
-
 #### Fixed Keys
 Fixed keys are really just a specialization of calculated keys.  A scenario that you may run into sometimes is where you only need a single key, which is the case when you only query the data using point queries ("get by id").  In this scenario, you'll probably choose to supply a partition key and not a row key since in this case you'd get better throughput using partition keys in a high volume system (again, we are assuming a point-query-only scenario).
 

src/TableStorage.Abstractions.POCO.SecondaryIndexes/PocoStoreIndexer.cs

@@ -490,7 +490,7 @@ public static async Task ReindexAsync<T, TPartitionKey, TRowKey>(this IPocoTable
 						{
 							foreach (var record in result.Items)
 							{
-								await semaphore.WaitAsync(TimeSpan.FromSeconds(20));
+								await semaphore.WaitAsync(TimeSpan.FromSeconds(20)).ConfigureAwait(false);
 								//Task task = indexStore.InsertOrReplaceAsync(record); //this line worked in the unit tests but not in a console app.  Not sure why.
 								var task = (Task) insertOrReplaceAsync.Invoke(indexStore, new object[] { record });
 								task.ContinueWith(r =>
@@ -512,7 +512,7 @@ public static async Task ReindexAsync<T, TPartitionKey, TRowKey>(this IPocoTable
 					while (semaphore.CurrentCount < maxDegreeOfParallelism)
 					{
 
-						await Task.Delay(5);
+						await Task.Delay(5).ConfigureAwait(false);
 					}
 					recordsIndexedCallback?.Invoke(count);
 				}

src/TableStorage.Abstractions.POCO.SecondaryIndexes/README.md

@@ -4,9 +4,9 @@
 This project builds on top of [TableStorage.Abstractions.POCO](https://github.com/giometrix/TableStorage.Abstractions.POCO) to introduce "secondary indexes" to [Azure Table Storage](https://github.com/giometrix/TableStorage.Abstractions.POCO). Internally this library uses an [intra/inter partition (or table) secondary index pattern](https://docs.microsoft.com/en-us/azure/storage/tables/table-storage-design-patterns).  When data gets mutated on your table store, the library takes care of reflecting the change in your secondary indexes.
 
 ## Caveats And Notes
-1. Indexes are managed through a library, _not_ Table Storage, thus data mutated outside of the library will not automatically be reflected in your indexes.
-2. Though Azure Table Storage does offer transactions within partitions, this library does not leverage this at this time.
-3. This library is intended for Azure Table Storage, not CosmosDB, which offers an Azure Table Storage API.  CosmosDB does offer secondary indexes, so this library may not be as useful there.
+1.  Indexes are managed through a library, _not_ Table Storage, thus data mutated outside of the library will not automatically be reflected in your indexes.
+2.  Though Azure Table Storage does offer transactions within partitions, this library does not leverage this at this time.
+3.  This library is intended for Azure Table Storage, not CosmosDB, which offers an Azure Table Storage API.  CosmosDB does offer secondary indexes, so this library may not be as useful there.
 
 ## Examples
 Note that it may be useful to read about [TableStorage.Abstractions.POCO](https://github.com/giometrix/TableStorage.Abstractions.POCO) to better understand the examples below.

src/TableStorage.Abstractions.POCO/PocoTableStore.cs

@@ -381,8 +381,11 @@ public IObservable<T> GetRecordsByFilterObservable(Func<T, bool> filter, int sta
 		/// <returns>Task.</returns>
 		public async Task CreateTableAsync()
 		{
-			await  _tableStore.CreateTableAsync();
-			if (OnTableCreatedAsync != null) await OnTableCreatedAsync(_tableName, this);
+			await  _tableStore.CreateTableAsync().ConfigureAwait(false);
+			if (OnTableCreatedAsync != null)
+			{
+				await OnTableCreatedAsync(_tableName, this).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -407,8 +410,11 @@ public async Task InsertAsync(T record)
 
 			var entity = CreateEntity(record);
 
-			await _tableStore.InsertAsync(entity);
-			if (OnRecordInsertedOrUpdatedAsync != null) await OnRecordInsertedOrUpdatedAsync(record);
+			await _tableStore.InsertAsync(entity).ConfigureAwait(false);
+			if (OnRecordInsertedOrUpdatedAsync != null)
+			{
+				await OnRecordInsertedOrUpdatedAsync(record).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -424,8 +430,11 @@ public async Task InsertOrReplaceAsync(T record)
 
 			var entity = CreateEntity(record);
 
-			await _tableStore.InsertOrReplaceAsync(entity);
-			if (OnRecordInsertedOrUpdatedAsync != null) await OnRecordInsertedOrUpdatedAsync(record);
+			await _tableStore.InsertOrReplaceAsync(entity).ConfigureAwait(false);
+			if (OnRecordInsertedOrUpdatedAsync != null)
+			{
+				await OnRecordInsertedOrUpdatedAsync(record).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -440,8 +449,11 @@ public async Task InsertAsync(IEnumerable<T> records)
 				throw new ArgumentNullException(nameof(records));
 
 			var entities = CreateEntities(records);
-			await _tableStore.InsertAsync(entities);
-			if (OnRecordsInsertedAsync != null) await OnRecordsInsertedAsync(records);
+			await _tableStore.InsertAsync(entities).ConfigureAwait(false);
+			if (OnRecordsInsertedAsync != null)
+			{
+				await OnRecordsInsertedAsync(records).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -452,8 +464,11 @@ public async Task InsertAsync(IEnumerable<T> records)
 		public async Task UpdateAsync(T record)
 		{
 			var entity = CreateEntityWithEtag(record);
-			await _tableStore.UpdateAsync(entity);
-			if (OnRecordInsertedOrUpdatedAsync != null) await OnRecordInsertedOrUpdatedAsync(record);
+			await _tableStore.UpdateAsync(entity).ConfigureAwait(false);
+			if (OnRecordInsertedOrUpdatedAsync != null)
+			{
+				await OnRecordInsertedOrUpdatedAsync(record).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -464,8 +479,11 @@ public async Task UpdateAsync(T record)
 		public async Task UpdateUsingWildcardEtagAsync(T record)
 		{
 			var entity = CreateEntity(record); 
-			await _tableStore.UpdateUsingWildcardEtagAsync(entity);
-			if (OnRecordInsertedOrUpdatedAsync != null) await OnRecordInsertedOrUpdatedAsync(record);
+			await _tableStore.UpdateUsingWildcardEtagAsync(entity).ConfigureAwait(false);
+			if (OnRecordInsertedOrUpdatedAsync != null)
+			{
+				await OnRecordInsertedOrUpdatedAsync(record).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -476,8 +494,11 @@ public async Task UpdateUsingWildcardEtagAsync(T record)
 		public async Task DeleteAsync(T record)
 		{
 			var entity = CreateEntityWithEtag(record);
-			await _tableStore.DeleteAsync(entity);
-			if (OnRecordDeletedAsync != null) await OnRecordDeletedAsync(record);
+			await _tableStore.DeleteAsync(entity).ConfigureAwait(false);
+			if (OnRecordDeletedAsync != null)
+			{
+				await OnRecordDeletedAsync(record).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -488,8 +509,11 @@ public async Task DeleteAsync(T record)
 		public async Task DeleteUsingWildcardEtagAsync(T record)
 		{
 			var entity = CreateEntity(record);
-			await _tableStore.DeleteUsingWildcardEtagAsync(entity);
-			if (OnRecordDeletedAsync != null) await OnRecordDeletedAsync(record);
+			await _tableStore.DeleteUsingWildcardEtagAsync(entity).ConfigureAwait(false);
+			if (OnRecordDeletedAsync != null)
+			{
+				await OnRecordDeletedAsync(record).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>
@@ -498,8 +522,11 @@ public async Task DeleteUsingWildcardEtagAsync(T record)
 		/// <returns>Task.</returns>
 		public async Task DeleteTableAsync()
 		{
-			await _tableStore.DeleteTableAsync();
-			if (OnTableDeletedAsync != null) await OnTableDeletedAsync(_tableName, this);
+			await _tableStore.DeleteTableAsync().ConfigureAwait(false);
+			if (OnTableDeletedAsync != null)
+			{
+				await OnTableDeletedAsync(_tableName, this).ConfigureAwait(false);
+			}
 		}
 
 		/// <summary>

tests/TableStorage.Abstractions.POCO.Tests/PartitionKey.cs

@@ -1,8 +1,6 @@
 namespace TableStorage.Abstractions.POCO.Tests
 {
-	public partial class PocoTableStoreTests
-	{
-		public class PartitionKey
+	public class PartitionKey
 		{
 			public PartitionKey(int companyId, int departmentId)
 			{
@@ -12,6 +10,5 @@ public PartitionKey(int companyId, int departmentId)
 			public int CompanyId { get; }
 			public int DepartmentId { get; }
 		}
-		
-	}
+	
 }

tests/TableStorage.Abstractions.POCO.Tests/PocoTableStoreTests.cs

@@ -10,7 +10,7 @@
 namespace TableStorage.Abstractions.POCO.Tests
 {
 	[TestClass]
-	public partial class PocoTableStoreTests
+	public class PocoTableStoreTests
 	{
 		private PocoTableStore<Employee, int, int> tableStore;