refactor

Author: giometrix

src/TableStorage.Abstractions.TableEntityConverters/EntityConvert.cs

@@ -12,8 +12,14 @@ public static class EntityConvert
 	{
 		private static JsonSerializerSettings _defaultJsonSerializerSettings = new JsonSerializerSettings();
 
-		public static JsonSerializerSettings DefaultJsonSerializerSettings {
-			set => _defaultJsonSerializerSettings = value ?? new JsonSerializerSettings();
+		/// <summary>
+		/// Json fields will use be serialized/deserialized with these provided settings when jsonSerializerSettings are
+		/// not explicitly passed into ToTableEntity/FromTableEntity
+		/// </summary>
+		/// <param name="jsonSerializerSettings">Note: null resets to default</param>
+		public static void SetDefaultJsonSerializerSettings (JsonSerializerSettings jsonSerializerSettings = default)
+		{
+			_defaultJsonSerializerSettings = jsonSerializerSettings ?? new JsonSerializerSettings();
 		}
 
 		public static DynamicTableEntity ToTableEntity<T>(this T o, string partitionKey, string rowKey,

src/TableStorage.Abstractions.UnitTests/EntityConvertTests.cs

@@ -10,7 +10,7 @@ public class EntityConvertTests
 	{
 		public EntityConvertTests()
 		{
-			EntityConvert.DefaultJsonSerializerSettings = null;
+			EntityConvert.SetDefaultJsonSerializerSettings();
 		}
 
 		public class GuidKeyTest
@@ -298,9 +298,9 @@ public void convert_to_entity_table()
 		[Fact]
 		public void convert_to_entity_table_custom_json_settings_as_a_global_setting()
 		{
-			EntityConvert.DefaultJsonSerializerSettings = new JsonSerializerSettings {
+			EntityConvert.SetDefaultJsonSerializerSettings(new JsonSerializerSettings {
 				NullValueHandling = NullValueHandling.Ignore,
-			};
+			});
 
 			var emp = new Employee
 			{
@@ -352,9 +352,9 @@ public void convert_to_entity_table_custom_json_settings_as_a_local_setting()
 		[Fact]
 		public void convert_from_entity_using_custom_json_settings_as_a_global_setting()
 		{
-			EntityConvert.DefaultJsonSerializerSettings = new JsonSerializerSettings {
+			EntityConvert.SetDefaultJsonSerializerSettings(new JsonSerializerSettings {
 				Converters = new List<JsonConverter>{new KeysJsonConverter(typeof(Department))}
-			};
+			});
 
 			var emp = new Employee
 			{