init: set up a better refspec

The previous 'git clone --mirror' approach also copied the 'refs/pull/*'
ref namespace, which is very noisy for the bundle server. Instead, focus
on the 'refs/heads/*' namespace and include only that during the
bundling process.

Author: derrickstolee

cmd/git-bundle-server/init.go

@@ -29,12 +29,22 @@ func (Init) run(args []string) error {
 	}
 
 	fmt.Printf("Cloning repository from %s\n", url)
-	gitErr := git.GitCommand("clone", "--mirror", url, repo.RepoDir)
+	gitErr := git.GitCommand("clone", "--bare", url, repo.RepoDir)
 
 	if gitErr != nil {
 		return fmt.Errorf("failed to clone repository: %w", gitErr)
 	}
 
+	gitErr = git.GitCommand("-C", repo.RepoDir, "config", "remote.origin.fetch", "+refs/heads/*:refs/heads/*")
+	if gitErr != nil {
+		return fmt.Errorf("failed to configure refspec: %w", gitErr)
+	}
+
+	gitErr = git.GitCommand("-C", repo.RepoDir, "fetch", "origin")
+	if gitErr != nil {
+		return fmt.Errorf("failed to fetch latest refs: %w", gitErr)
+	}
+
 	bundle := bundles.CreateInitialBundle(repo)
 	fmt.Printf("Constructing base bundle file at %s\n", bundle.Filename)
 

internal/git/git.go

@@ -75,7 +75,7 @@ func GitCommandWithStdin(stdinLines []string, args ...string) error {
 func CreateBundle(repoDir string, filename string) (bool, error) {
 	err := GitCommand(
 		"-C", repoDir, "bundle", "create",
-		filename, "--all")
+		filename, "--branches")
 	if err != nil {
 		if strings.Contains(err.Error(), "Refusing to create empty bundle") {
 			return false, nil
@@ -112,7 +112,7 @@ func CreateBundleFromRefs(repoDir string, filename string, refs map[string]strin
 func CreateIncrementalBundle(repoDir string, filename string, prereqs []string) (bool, error) {
 	err := GitCommandWithStdin(
 		prereqs, "-C", repoDir, "bundle", "create",
-		filename, "--stdin", "--all")
+		filename, "--stdin", "--branches")
 	if err != nil {
 		if strings.Contains(err.Error(), "Refusing to create empty bundle") {
 			return false, nil