cmd: add logger to 'CommandExecutor'

Initialize the 'CommandExecutor' with an instance of 'log.TraceLogger',
consistent with other structures (e.g. 'core.RepoProvider'). This will be
used to log the setup and run operations of the executor in later commits.

Signed-off-by: Victoria Dye <[email protected]>

Author: vdye

cmd/utils/container-helpers.go

@@ -17,7 +17,7 @@ func BuildGitBundleServerContainer(logger log.TraceLogger) *DependencyContainer
 		return common.NewUserProvider()
 	})
 	registerDependency(container, func(ctx context.Context) cmd.CommandExecutor {
-		return cmd.NewCommandExecutor()
+		return cmd.NewCommandExecutor(logger)
 	})
 	registerDependency(container, func(ctx context.Context) common.FileSystem {
 		return common.NewFileSystem()

internal/cmd/command.go

@@ -2,31 +2,36 @@ package cmd
 
 import (
 	"context"
-	"fmt"
 	"os/exec"
+
+	"github.com/github/git-bundle-server/internal/log"
 )
 
 type CommandExecutor interface {
 	Run(ctx context.Context, command string, args ...string) (int, error)
 }
 
-type commandExecutor struct{}
+type commandExecutor struct {
+	logger log.TraceLogger
+}
 
-func NewCommandExecutor() CommandExecutor {
-	return &commandExecutor{}
+func NewCommandExecutor(l log.TraceLogger) CommandExecutor {
+	return &commandExecutor{
+		logger: l,
+	}
 }
 
 func (c *commandExecutor) Run(ctx context.Context, command string, args ...string) (int, error) {
 	exe, err := exec.LookPath(command)
 	if err != nil {
-		return -1, fmt.Errorf("failed to find '%s' on the path: %w", command, err)
+		return -1, c.logger.Errorf(ctx, "failed to find '%s' on the path: %w", command, err)
 	}
 
 	cmd := exec.Command(exe, args...)
 
 	err = cmd.Start()
 	if err != nil {
-		return -1, fmt.Errorf("command failed to start: %w", err)
+		return -1, c.logger.Errorf(ctx, "command failed to start: %w", err)
 	}
 
 	err = cmd.Wait()
@@ -37,6 +42,6 @@ func (c *commandExecutor) Run(ctx context.Context, command string, args ...strin
 	if err == nil || isExitError {
 		return cmd.ProcessState.ExitCode(), nil
 	} else {
-		return -1, err
+		return -1, c.logger.Error(ctx, err)
 	}
 }