cmd: move command.go into a new package

Move 'command.go' (containing the 'CommandExecutor' interface) into a new
package 'cmd'. This helps set up for future enhancements to the interface,
including the addition of supplemental types (like 'cmd.Setting', used to
configure the behavior of the 'Run()' function).

Signed-off-by: Victoria Dye <[email protected]>

Author: vdye

cmd/utils/container-helpers.go

@@ -4,6 +4,7 @@ import (
 	"context"
 
 	"github.com/github/git-bundle-server/internal/bundles"
+	"github.com/github/git-bundle-server/internal/cmd"
 	"github.com/github/git-bundle-server/internal/common"
 	"github.com/github/git-bundle-server/internal/core"
 	"github.com/github/git-bundle-server/internal/daemon"
@@ -15,8 +16,8 @@ func BuildGitBundleServerContainer(logger log.TraceLogger) *DependencyContainer
 	registerDependency(container, func(ctx context.Context) common.UserProvider {
 		return common.NewUserProvider()
 	})
-	registerDependency(container, func(ctx context.Context) common.CommandExecutor {
-		return common.NewCommandExecutor()
+	registerDependency(container, func(ctx context.Context) cmd.CommandExecutor {
+		return cmd.NewCommandExecutor()
 	})
 	registerDependency(container, func(ctx context.Context) common.FileSystem {
 		return common.NewFileSystem()
@@ -35,7 +36,7 @@ func BuildGitBundleServerContainer(logger log.TraceLogger) *DependencyContainer
 		t, err := daemon.NewDaemonProvider(
 			logger,
 			GetDependency[common.UserProvider](ctx, container),
-			GetDependency[common.CommandExecutor](ctx, container),
+			GetDependency[cmd.CommandExecutor](ctx, container),
 			GetDependency[common.FileSystem](ctx, container),
 		)
 		if err != nil {

internal/common/command.go renamed to internal/cmd/command.go

@@ -1,4 +1,4 @@
-package common
+package cmd
 
 import (
 	"fmt"

internal/daemon/daemon.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"runtime"
 
+	"github.com/github/git-bundle-server/internal/cmd"
 	"github.com/github/git-bundle-server/internal/common"
 	"github.com/github/git-bundle-server/internal/log"
 )
@@ -29,7 +30,7 @@ type DaemonProvider interface {
 func NewDaemonProvider(
 	l log.TraceLogger,
 	u common.UserProvider,
-	c common.CommandExecutor,
+	c cmd.CommandExecutor,
 	fs common.FileSystem,
 ) (DaemonProvider, error) {
 	switch thisOs := runtime.GOOS; thisOs {

internal/daemon/launchd.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"path/filepath"
 
+	"github.com/github/git-bundle-server/internal/cmd"
 	"github.com/github/git-bundle-server/internal/common"
 	"github.com/github/git-bundle-server/internal/log"
 	"github.com/github/git-bundle-server/internal/utils"
@@ -94,14 +95,14 @@ func (c *launchdConfig) toPlist() *plist {
 type launchd struct {
 	logger     log.TraceLogger
 	user       common.UserProvider
-	cmdExec    common.CommandExecutor
+	cmdExec    cmd.CommandExecutor
 	fileSystem common.FileSystem
 }
 
 func NewLaunchdProvider(
 	l log.TraceLogger,
 	u common.UserProvider,
-	c common.CommandExecutor,
+	c cmd.CommandExecutor,
 	fs common.FileSystem,
 ) DaemonProvider {
 	return &launchd{

internal/daemon/systemd.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"text/template"
 
+	"github.com/github/git-bundle-server/internal/cmd"
 	"github.com/github/git-bundle-server/internal/common"
 	"github.com/github/git-bundle-server/internal/log"
 )
@@ -25,14 +26,14 @@ const SystemdUnitNotInstalledErrorCode int = 5
 type systemd struct {
 	logger     log.TraceLogger
 	user       common.UserProvider
-	cmdExec    common.CommandExecutor
+	cmdExec    cmd.CommandExecutor
 	fileSystem common.FileSystem
 }
 
 func NewSystemdProvider(
 	l log.TraceLogger,
 	u common.UserProvider,
-	c common.CommandExecutor,
+	c cmd.CommandExecutor,
 	fs common.FileSystem,
 ) DaemonProvider {
 	return &systemd{