Issue #218 Address PR comments with minor updates to XUnit usage and removed unused code and out of date comments

Author: mminns

src/shared/Atlassian.Bitbucket.Tests/BitbucketAuthenticationTest.cs

@@ -25,9 +25,8 @@ public async Task BitbucketAuthentication_GetBasicCredentialsAsync_SucceedsAfter
             Assert.Equal(password, result.Password);
         }
 
-        [Theory]
-        [InlineData("jsquire", "password")]
-        public async Task BitbucketAuthentication_ShowOAuthRequiredPromptAsync_SucceedsAfterUserInput(string username, string password)
+        [Fact]
+        public async Task BitbucketAuthentication_ShowOAuthRequiredPromptAsync_SucceedsAfterUserInput()
         {
             var context = new TestCommandContext();
             context.Terminal.Prompts["Press enter to continue..."] = " ";

src/shared/Atlassian.Bitbucket.Tests/BitbucketHostProviderTest.cs

@@ -56,15 +56,15 @@ public void BitbucketHostProvider_IsSupported_FailsForNullInput()
         {
             InputArguments input = null;
             var provider = new BitbucketHostProvider(new TestCommandContext());
-            Assert.Equal(false, provider.IsSupported(input));
+            Assert.False(provider.IsSupported(input));
         }
 
         [Fact]
         public void BitbucketHostProvider_IsSupported_FailsForNullHttpResponseMessage()
         {
             HttpResponseMessage httpResponseMessage = null;
             var provider = new BitbucketHostProvider(new TestCommandContext());
-            Assert.Equal(false, provider.IsSupported(httpResponseMessage));
+            Assert.False(provider.IsSupported(httpResponseMessage));
         }
 
         [Theory]

src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs

@@ -144,9 +144,6 @@ private async Task<ICredential> GetRefreshedCredentials(InputArguments input)
                 // There is no refresh token either because this is a non-2FA enabled account (where OAuth is not
                 // required), or because we previously erased the RT.
 
-                // Check for the presence of a credential in the store
-                string credentialService = GetServiceName(input);
-
                 if (SupportsBasicAuth(authModes))
                 {
                     _context.Trace.WriteLine("Prompt for Basic Auth...");
@@ -181,9 +178,6 @@ private async Task<ICredential> GetRefreshedCredentials(InputArguments input)
             {
                 _context.Trace.WriteLineSecrets($"Found stored refresh token: {{0}}", new object[] { refreshToken });
 
-                // It's very likely that any access token expired between the last time we used/stored it.
-                // To ensure the AT is as 'fresh' as it can be, always first try to use the refresh token
-                // (which lives longer) to create a new AT (and possibly also a new RT).
                 try
                 {
                     return await GetOAuthCredentialsViaRefreshFlow(input, refreshToken);