Add Azure Repos host provider configuration component

Add the required configuration/unconfiguration to the Azure Repos host
provider.

The required config is to set `useHttpPath` to true for dev.azure.com
hosts.

Author: mjcheetham

src/shared/Microsoft.AzureRepos.Tests/AzureReposHostProviderTests.cs

@@ -13,6 +13,9 @@ namespace Microsoft.AzureRepos.Tests
 {
     public class AzureReposHostProviderTests
     {
+        private static readonly string AzDevUseHttpPathKey =
+            $"{Constants.GitConfiguration.Credential.SectionName}.https://dev.azure.com.{Constants.GitConfiguration.Credential.UseHttpPath}";
+
         [Fact]
         public void AzureReposProvider_IsSupported_AzureHost_UnencryptedHttp_ReturnsTrue()
         {
@@ -171,5 +174,84 @@ public async Task AzureReposProvider_GetCredentialAsync_ReturnsCredential()
             Assert.Equal(personalAccessToken, credential.Password);
             // We don't care about the username value
         }
+
+        [Fact]
+        public async Task AzureReposHostProvider_ConfigureAsync_UseHttpPathSetTrue_DoesNothing()
+        {
+            var provider = new AzureReposHostProvider(new TestCommandContext());
+
+            var environment = new TestEnvironment();
+            var config = new TestGitConfiguration(new Dictionary<string, IList<string>>
+            {
+                [AzDevUseHttpPathKey] = new List<string> {"true"}
+            });
+
+            await provider.ConfigureAsync(
+                environment, EnvironmentVariableTarget.User,
+                config, GitConfigurationLevel.Global);
+
+            Assert.Single(config.Dictionary);
+            Assert.True(config.Dictionary.TryGetValue(AzDevUseHttpPathKey, out IList<string> actualValues));
+            Assert.Single(actualValues);
+            Assert.Equal("true", actualValues[0]);
+        }
+
+        [Fact]
+        public async Task AzureReposHostProvider_ConfigureAsync_UseHttpPathSetFalse_SetsUseHttpPathTrue()
+        {
+            var provider = new AzureReposHostProvider(new TestCommandContext());
+
+            var environment = new TestEnvironment();
+            var config = new TestGitConfiguration(new Dictionary<string, IList<string>>
+            {
+                [AzDevUseHttpPathKey] = new List<string> {"false"}
+            });
+
+            await provider.ConfigureAsync(
+                environment, EnvironmentVariableTarget.User,
+                config, GitConfigurationLevel.Global);
+
+            Assert.Single(config.Dictionary);
+            Assert.True(config.Dictionary.TryGetValue(AzDevUseHttpPathKey, out IList<string> actualValues));
+            Assert.Single(actualValues);
+            Assert.Equal("true", actualValues[0]);
+        }
+
+        [Fact]
+        public async Task AzureReposHostProvider_ConfigureAsync_UseHttpPathUnset_SetsUseHttpPathTrue()
+        {
+            var provider = new AzureReposHostProvider(new TestCommandContext());
+
+            var environment = new TestEnvironment();
+            var config = new TestGitConfiguration();
+
+            await provider.ConfigureAsync(
+                environment, EnvironmentVariableTarget.User,
+                config, GitConfigurationLevel.Global);
+
+            Assert.Single(config.Dictionary);
+            Assert.True(config.Dictionary.TryGetValue(AzDevUseHttpPathKey, out IList<string> actualValues));
+            Assert.Single(actualValues);
+            Assert.Equal("true", actualValues[0]);
+        }
+
+
+        [Fact]
+        public async Task AzureReposHostProvider_UnconfigureAsync_UseHttpPathSet_RemovesEntry()
+        {
+            var provider = new AzureReposHostProvider(new TestCommandContext());
+
+            var environment = new TestEnvironment();
+            var config = new TestGitConfiguration(new Dictionary<string, IList<string>>
+            {
+                [AzDevUseHttpPathKey] = new List<string> {"true"}
+            });
+
+            await provider.UnconfigureAsync(
+                environment, EnvironmentVariableTarget.User,
+                config, GitConfigurationLevel.Global);
+
+            Assert.Empty(config.Dictionary);
+        }
     }
 }

src/shared/Microsoft.AzureRepos/AzureReposHostProvider.cs

@@ -5,10 +5,11 @@
 using System.Threading.Tasks;
 using Microsoft.Git.CredentialManager;
 using Microsoft.Git.CredentialManager.Authentication;
+using KnownGitCfg = Microsoft.Git.CredentialManager.Constants.GitConfiguration;
 
 namespace Microsoft.AzureRepos
 {
-    public class AzureReposHostProvider : HostProvider
+    public class AzureReposHostProvider : HostProvider, IConfigurableComponent
     {
         private readonly IAzureDevOpsRestApi _azDevOps;
         private readonly IMicrosoftAuthentication _msAuth;
@@ -103,5 +104,49 @@ protected override void ReleaseManagedResources()
         }
 
         #endregion
+
+        #region IConfigurationComponent
+
+        string IConfigurableComponent.Name => "Azure Repos provider";
+
+        public Task ConfigureAsync(
+            IEnvironment environment, EnvironmentVariableTarget environmentTarget,
+            IGitConfiguration configuration, GitConfigurationLevel configurationLevel)
+        {
+            string useHttpPathKey = $"{KnownGitCfg.Credential.SectionName}.https://dev.azure.com.{KnownGitCfg.Credential.UseHttpPath}";
+
+            using (IGitConfiguration targetConfig = configuration.GetFilteredConfiguration(configurationLevel))
+            {
+                if (targetConfig.TryGetValue(useHttpPathKey, out string currentValue) && currentValue.IsTruthy())
+                {
+                    Context.Trace.WriteLine("Git configuration 'credential.useHttpPath' is already set to 'true' for https://dev.azure.com.");
+                }
+                else
+                {
+                    Context.Trace.WriteLine("Setting Git configuration 'credential.useHttpPath' to 'true' for https://dev.azure.com...");
+                    targetConfig.SetValue(useHttpPathKey, "true");
+                }
+            }
+
+            return Task.CompletedTask;
+        }
+
+        public Task UnconfigureAsync(
+            IEnvironment environment, EnvironmentVariableTarget environmentTarget,
+            IGitConfiguration configuration, GitConfigurationLevel configurationLevel)
+        {
+            string useHttpPathKey = $"{KnownGitCfg.Credential.SectionName}.https://dev.azure.com.{KnownGitCfg.Credential.UseHttpPath}";
+
+            Context.Trace.WriteLine("Clearing Git configuration 'credential.useHttpPath' for https://dev.azure.com...");
+
+            using (IGitConfiguration targetConfig = configuration.GetFilteredConfiguration(configurationLevel))
+            {
+                targetConfig.DeleteEntry(useHttpPathKey);
+            }
+
+            return Task.CompletedTask;
+        }
+
+        #endregion
     }
 }

src/shared/Microsoft.Git.CredentialManager.Tests/ApplicationTests.cs

@@ -157,12 +157,13 @@ await application.UnconfigureAsync(
         [PlatformFact(Platform.Windows)]
         public async Task Application_ConfigureAsync_User_PathSet_DoesNothing()
         {
-            const string executablePath = "/usr/local/share/gcm-core/git-credential-manager-core";
+            const string directoryPath = @"X:\Install Location";
+            const string executablePath = @"X:\Install Location\git-credential-manager-core.exe";
 
             IConfigurableComponent application = new Application(new TestCommandContext(), executablePath);
 
             var environment = new Mock<IEnvironment>();
-            environment.Setup(x => x.IsDirectoryOnPath("/usr/local/share/gcm-core")).Returns(true);
+            environment.Setup(x => x.IsDirectoryOnPath(directoryPath)).Returns(true);
 
             var config = new TestGitConfiguration();
 
@@ -176,12 +177,13 @@ await application.ConfigureAsync(
         [PlatformFact(Platform.Windows)]
         public async Task Application_ConfigureAsync_User_PathNotSet_SetsUserPath()
         {
-            const string executablePath = "/usr/local/share/gcm-core/git-credential-manager-core";
+            const string directoryPath = @"X:\Install Location";
+            const string executablePath = @"X:\Install Location\git-credential-manager-core.exe";
 
             IConfigurableComponent application = new Application(new TestCommandContext(), executablePath);
 
             var environment = new Mock<IEnvironment>();
-            environment.Setup(x => x.IsDirectoryOnPath("/usr/local/share/gcm-core")).Returns(false);
+            environment.Setup(x => x.IsDirectoryOnPath(directoryPath)).Returns(false);
 
             var config = new TestGitConfiguration();
 
@@ -195,12 +197,13 @@ await application.ConfigureAsync(
         [PlatformFact(Platform.Windows)]
         public async Task Application_UnconfigureAsync_User_PathSet_RemovesFromUserPath()
         {
-            const string executablePath = "/usr/local/share/gcm-core/git-credential-manager-core";
+            const string directoryPath = @"X:\Install Location";
+            const string executablePath = @"X:\Install Location\git-credential-manager-core.exe";
 
             IConfigurableComponent application = new Application(new TestCommandContext(), executablePath);
 
             var environment = new Mock<IEnvironment>();
-            environment.Setup(x => x.IsDirectoryOnPath("/usr/local/share/gcm-core")).Returns(true);
+            environment.Setup(x => x.IsDirectoryOnPath(directoryPath)).Returns(true);
 
             var config = new TestGitConfiguration();