Merge pull request #529 from mjcheetham/wslview

mjcheetham · web-flow · commit 0d360acafc5c · 2021-11-16T11:31:46.000Z
Use wslview to launch browser in Windows from WSL
diff --git a/src/shared/Core/BrowserUtils.cs b/src/shared/Core/BrowserUtils.cs
@@ -39,7 +39,11 @@ public static void OpenDefaultBrowser(IEnvironment environment, Uri uri)
                 //
                 // We try and use the same 'shell execute' utilities as the Framework does,
                 // searching for them in the same order until we find one.
-                foreach (string shellExec in new[] {"xdg-open", "gnome-open", "kfmclient"})
+                //
+                // One additional 'shell execute' utility we also attempt to use is `wslview`
+                // that is commonly found on WSL (Windows Subsystem for Linux) distributions that
+                // opens the browser on the Windows host.
+                foreach (string shellExec in new[] {"xdg-open", "gnome-open", "kfmclient", "wslview"})
                 {
                     if (environment.TryLocateExecutable(shellExec, out string shellExecPath))
                     {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,11 @@ public static void OpenDefaultBrowser(IEnvironment environment, Uri uri)`
`39`	`39`	`//`
`40`	`40`	`// We try and use the same 'shell execute' utilities as the Framework does,`
`41`	`41`	`// searching for them in the same order until we find one.`
`42`		`- foreach (string shellExec in new[] {"xdg-open", "gnome-open", "kfmclient"})`
	`42`	`+ //`
	`43`	+ // One additional 'shell execute' utility we also attempt to use is `wslview`
	`44`	`+ // that is commonly found on WSL (Windows Subsystem for Linux) distributions that`
	`45`	`+ // opens the browser on the Windows host.`
	`46`	`+ foreach (string shellExec in new[] {"xdg-open", "gnome-open", "kfmclient", "wslview"})`
`43`	`47`	`{`
`44`	`48`	`if (environment.TryLocateExecutable(shellExec, out string shellExecPath))`
`45`	`49`	`{`