Skip to content

Commit 1f8e978

Browse files
authored
Merge pull request #851 from ldennington/remove-azure-storage-key
release: access Azure Storage Account with login credentials
2 parents c2c0cdc + 8bc6801 commit 1f8e978

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.github/set_up_esrp.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Install ESRP client
2-
az storage blob download --file esrp.zip --account-key "$env:AZURE_STORAGE_KEY" --account-name esrpsigningstorage --container signing-resources --name microsoft.esrpclient.1.2.76.nupkg
2+
az storage blob download --file esrp.zip --auth-mode login --account-name esrpsigningstorage --container signing-resources --name microsoft.esrpclient.1.2.76.nupkg
33
Expand-Archive -Path esrp.zip -DestinationPath .\esrp
44

55
# Install certificates

.github/workflows/release.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ jobs:
101101
- name: Set up ESRP client
102102
shell: pwsh
103103
env:
104-
AZURE_STORAGE_KEY: ${{ secrets.AZURE_STORAGE_KEY }}
105104
AZURE_VAULT: ${{ secrets.AZURE_VAULT }}
106105
AUTH_CERT: ${{ secrets.AZURE_VAULT_AUTH_CERT_NAME }}
107106
REQUEST_SIGNING_CERT: ${{ secrets.AZURE_VAULT_REQUEST_SIGNING_CERT_NAME }}
@@ -211,7 +210,6 @@ jobs:
211210
- name: Set up ESRP client
212211
shell: pwsh
213212
env:
214-
AZURE_STORAGE_KEY: ${{ secrets.AZURE_STORAGE_KEY }}
215213
AZURE_VAULT: ${{ secrets.AZURE_VAULT }}
216214
AUTH_CERT: ${{ secrets.AZURE_VAULT_AUTH_CERT_NAME }}
217215
REQUEST_SIGNING_CERT: ${{ secrets.AZURE_VAULT_REQUEST_SIGNING_CERT_NAME }}
@@ -296,7 +294,6 @@ jobs:
296294
- name: Set up ESRP client
297295
shell: pwsh
298296
env:
299-
AZURE_STORAGE_KEY: ${{ secrets.AZURE_STORAGE_KEY }}
300297
AZURE_VAULT: ${{ secrets.AZURE_VAULT }}
301298
AUTH_CERT: ${{ secrets.AZURE_VAULT_AUTH_CERT_NAME }}
302299
REQUEST_SIGNING_CERT: ${{ secrets.AZURE_VAULT_REQUEST_SIGNING_CERT_NAME }}
@@ -414,7 +411,6 @@ jobs:
414411
- name: Set up ESRP client
415412
shell: pwsh
416413
env:
417-
AZURE_STORAGE_KEY: ${{ secrets.AZURE_STORAGE_KEY }}
418414
AZURE_VAULT: ${{ secrets.AZURE_VAULT }}
419415
AUTH_CERT: ${{ secrets.AZURE_VAULT_AUTH_CERT_NAME }}
420416
REQUEST_SIGNING_CERT: ${{ secrets.AZURE_VAULT_REQUEST_SIGNING_CERT_NAME }}

0 commit comments

Comments
 (0)