trace2: remove warning from tryparsesettings

ldennington · ldennington · commit 20415232d5ba · 2023-02-15T17:58:39.000-07:00
Remove warning about being unable to set up tracing from Trace2
TryParseSettings method. This method should just check to see whether
TRACE2 is enabled - if it is not, it does not need to warn the user, as
we only collect traces from those who actively choose to opt in.
diff --git a/src/shared/Core/Trace2.cs b/src/shared/Core/Trace2.cs
@@ -200,11 +200,6 @@ private void TryParseSettings(TextWriter error, IFileSystem fileSystem)
                 }
             }
         }
-
-        if (_writers.Count == 0)
-        {
-            error.WriteLine("warning: unable to set up TRACE2 tracing. No traces will be written.");
-        }
     }
 
     private void WriteVersion(

Original file line number	Diff line number	Diff line change
`@@ -200,11 +200,6 @@ private void TryParseSettings(TextWriter error, IFileSystem fileSystem)`
`200`	`200`	`}`
`201`	`201`	`}`
`202`	`202`	`}`
`203`		`-`
`204`		`- if (_writers.Count == 0)`
`205`		`- {`
`206`		`- error.WriteLine("warning: unable to set up TRACE2 tracing. No traces will be written.");`
`207`		`- }`
`208`	`203`	`}`
`209`	`204`
`210`	`205`	`private void WriteVersion(`