Skip to content

Commit 2fd111b

Browse files
authored
release: update Linux, macOS, and Windows signing (#1431)
This PR migrates GCM's Linux, macOS, and Windows signing workflows off the ESRP service. This means: 1. Updating the Linux components to sign with a GPG key. 2. Updating macOS components to sign/notarize using Application and Installer certificates (see this series [1] for details). 3. Updating Windows components to sign using the Azure Code Signing service. **Note:** This PR does not include updates to migrate the .NET tool package signing off ESRP for two reasons: 1. The Azure Code Signing service does not yet support NuGet package signing. We are hopeful this will be our solution in the future, though. 2. HSM requirements for Code Signing certificate storage [2]. An example run of release workflow with these changes can be found here [3]. 1: https://developer.apple.com/forums/thread/701514 2: https://knowledge.digicert.com/generalinformation/new-private-key-storage-requirement-for-standard-code-signing-certificates-november-2022.html 3: https://github.com/ldennington/git-credential-manager/actions/runs/6543297870
2 parents 62eb6ab + 8f93d56 commit 2fd111b

File tree

7 files changed

+403
-372
lines changed

7 files changed

+403
-372
lines changed

.github/set_up_esrp.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Install ESRP client
2-
az storage blob download --file esrp.zip --auth-mode login --account-name esrpsigningstorage --container signing-resources --name microsoft.esrpclient.1.2.76.nupkg
2+
az storage blob download --file esrp.zip --auth-mode login --account-name $env:AZURE_STORAGE_ACCOUNT --container $env:AZURE_STORAGE_CONTAINER --name $env:ESRP_TOOL
33
Expand-Archive -Path esrp.zip -DestinationPath .\esrp
44

55
# Install certificates

0 commit comments

Comments
 (0)