github: add in-proc UI implementation

Author: mjcheetham

src/shared/GitHub.Tests/GitHubAuthenticationTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Threading.Tasks;
+using Avalonia.Animation;
 using GitCredentialManager;
 using GitCredentialManager.Tests.Objects;
 using Moq;
@@ -78,10 +79,14 @@ public async Task GitHubAuthentication_GetAuthenticationAsync_AuthenticationMode
         [Fact]
         public async Task GitHubAuthentication_GetAuthenticationAsync_Helper_Basic()
         {
+            const string unixHelperPath = "/usr/local/bin/GitHub.UI";
+            const string windowsHelperPath = @"C:\Program Files\Git Credential Manager\GitHub.UI.exe";
+            string helperPath = PlatformUtils.IsWindows() ? windowsHelperPath : unixHelperPath;
+
             var context = new TestCommandContext();
-            context.FileSystem.Files["/usr/local/bin/GitHub.UI"] = new byte[0];
-            context.FileSystem.Files[@"C:\Program Files\Git Credential Manager Core\GitHub.UI.exe"] = new byte[0];
+            context.FileSystem.Files[helperPath] = Array.Empty<byte>();
             context.SessionManager.IsDesktopSession = true;
+            context.Environment.Variables[GitHubConstants.EnvironmentVariables.AuthenticationHelper] = helperPath;
             var auth = new Mock<GitHubAuthentication>(MockBehavior.Strict, context);
             auth.Setup(x => x.InvokeHelperAsync(It.IsAny<string>(), "prompt --all", It.IsAny<IDictionary<string, string>>(), It.IsAny<System.Threading.CancellationToken>()))
             .Returns(Task.FromResult<IDictionary<string, string>>(

src/shared/GitHub/GitHubAuthentication.cs

@@ -7,6 +7,9 @@
 using GitCredentialManager;
 using GitCredentialManager.Authentication;
 using GitCredentialManager.Authentication.OAuth;
+using GitCredentialManager.UI;
+using GitHub.UI.ViewModels;
+using GitHub.UI.Views;
 
 namespace GitHub
 {
@@ -86,15 +89,69 @@ public async Task<AuthenticationPromptResult> GetAuthenticationAsync(Uri targetU
 
             ThrowIfUserInteractionDisabled();
 
-            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession &&
-                TryFindHelperCommand(out string command, out string args))
+            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession)
             {
-                return await GetAuthenticationViaHelperAsync(targetUri, userName, modes, command, args);
+                if (TryFindHelperCommand(out string command, out string args))
+                {
+                    return await GetAuthenticationViaHelperAsync(targetUri, userName, modes, command, args);
+                }
+
+                return await GetAuthenticationViaUiAsync(targetUri, userName, modes);
             }
 
             return GetAuthenticationViaTty(targetUri, userName, modes);
         }
 
+        private async Task<AuthenticationPromptResult> GetAuthenticationViaUiAsync(
+            Uri targetUri, string userName, AuthenticationModes modes)
+        {
+            var viewModel = new CredentialsViewModel(Context.Environment, Context.ProcessManager)
+            {
+                ShowBrowserLogin = (modes & AuthenticationModes.Browser) != 0,
+                ShowDeviceLogin  = (modes & AuthenticationModes.Device) != 0,
+                ShowTokenLogin   = (modes & AuthenticationModes.Pat) != 0,
+                ShowBasicLogin   = (modes & AuthenticationModes.Basic) != 0,
+            };
+
+            if (!GitHubHostProvider.IsGitHubDotCom(targetUri))
+            {
+                viewModel.EnterpriseUrl = targetUri.ToString();
+            }
+
+            if (!string.IsNullOrWhiteSpace(userName))
+            {
+                viewModel.UserName = userName;
+            }
+
+            await AvaloniaUi.ShowViewAsync<CredentialsView>(viewModel, GetParentWindowHandle(), CancellationToken.None);
+
+            ThrowIfWindowCancelled(viewModel);
+
+            switch (viewModel.SelectedMode)
+            {
+                case AuthenticationModes.Basic:
+                    return new AuthenticationPromptResult(
+                        AuthenticationModes.Basic,
+                        new GitCredential(viewModel.UserName, viewModel.Password)
+                    );
+
+                case AuthenticationModes.Browser:
+                    return new AuthenticationPromptResult(AuthenticationModes.Browser);
+
+                case AuthenticationModes.Device:
+                    return new AuthenticationPromptResult(AuthenticationModes.Device);
+
+                case AuthenticationModes.Pat:
+                    return new AuthenticationPromptResult(
+                        AuthenticationModes.Pat,
+                        new GitCredential(userName, viewModel.Password)
+                    );
+
+                default:
+                    throw new ArgumentOutOfRangeException();
+            }
+        }
+
         private AuthenticationPromptResult GetAuthenticationViaTty(Uri targetUri, string userName, AuthenticationModes modes)
         {
             ThrowIfTerminalPromptsDisabled();
@@ -229,15 +286,33 @@ public async Task<string> GetTwoFactorCodeAsync(Uri targetUri, bool isSms)
         {
             ThrowIfUserInteractionDisabled();
 
-            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession &&
-                TryFindHelperCommand(out string command, out string args))
+            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession)
             {
-                return await GetTwoFactorCodeViaHelperAsync(isSms, args, command);
+                if (TryFindHelperCommand(out string command, out string args))
+                {
+                    return await GetTwoFactorCodeViaHelperAsync(isSms, args, command);
+                }
+
+                return await GetTwoFactorCodeViaUiAsync(targetUri, isSms);
             }
 
             return GetTwoFactorCodeViaTty(isSms);
         }
 
+        private async Task<string> GetTwoFactorCodeViaUiAsync(Uri targetUri, bool isSms)
+        {
+            var viewModel = new TwoFactorViewModel(Context.Environment, Context.ProcessManager)
+            {
+                IsSms = isSms
+            };
+
+            await AvaloniaUi.ShowViewAsync<TwoFactorView>(viewModel, GetParentWindowHandle(), CancellationToken.None);
+            
+            ThrowIfWindowCancelled(viewModel);
+
+            return viewModel.Code;
+        }
+
         private string GetTwoFactorCodeViaTty(bool isSms)
         {
             ThrowIfTerminalPromptsDisabled();
@@ -314,14 +389,15 @@ public async Task<OAuth2TokenResult> GetOAuthTokenViaDeviceCodeAsync(Uri targetU
             OAuth2DeviceCodeResult dcr = await oauthClient.GetDeviceCodeAsync(scopes, CancellationToken.None);
 
             // If we have a desktop session show the device code in a dialog
-            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession &&
-                TryFindHelperCommand(out string command, out string args))
+            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession)
             {
                 var promptCts = new CancellationTokenSource();
                 var tokenCts = new CancellationTokenSource();
 
                 // Show the dialog with the device code but don't await its closure
-                Task promptTask = ShowDeviceCodeViaHelperAsync(dcr, command, args, promptCts.Token);
+                Task promptTask = TryFindHelperCommand(out string command, out string args)
+                    ? ShowDeviceCodeViaHelperAsync(dcr, command, args, promptCts.Token)
+                    : ShowDeviceCodeViaUiAsync(dcr, promptCts.Token);
 
                 // Start the request for an OAuth token but don't wait
                 Task<OAuth2TokenResult> tokenTask = oauthClient.GetTokenByDeviceCodeAsync(dcr, tokenCts.Token);
@@ -354,6 +430,17 @@ public async Task<OAuth2TokenResult> GetOAuthTokenViaDeviceCodeAsync(Uri targetU
             return await GetOAuthTokenViaDeviceCodeViaTtyAsync(oauthClient, dcr);
         }
 
+        private Task ShowDeviceCodeViaUiAsync(OAuth2DeviceCodeResult dcr, CancellationToken ct)
+        {
+            var viewModel = new DeviceCodeViewModel(Context.Environment)
+            {
+                UserCode = dcr.UserCode,
+                VerificationUrl = dcr.VerificationUri.ToString(),
+            };
+
+            return AvaloniaUi.ShowViewAsync<DeviceCodeView>(viewModel, GetParentWindowHandle(), ct);
+        }
+
         private async Task<OAuth2TokenResult> GetOAuthTokenViaDeviceCodeViaTtyAsync(GitHubOAuth2Client oauthClient, OAuth2DeviceCodeResult dcr)
         {
             ThrowIfTerminalPromptsDisabled();