settings: fix bug in path-type setting reading

If we are asked for a path-type setting then we should always consult
Git directly for the value, and not used cached copies of values that
were acquired using `git config list` without a `--type` parameter.

Author: mjcheetham

src/shared/Core/Settings.cs

@@ -397,8 +397,8 @@ public IEnumerable<string> GetSettingValues(string envarName, string section, st
                         // Look for a scoped entry that includes the scheme "protocol://example.com" first as
                         // this is more specific. If `isPath` is true, then re-get the value from the
                         // `GitConfiguration` with `isPath` specified.
-                        if (configEntries.TryGetValue(queryName, out value) &&
-                            (!isPath || config.TryGet(queryName, isPath, out value)))
+                        if ((isPath && config.TryGet(queryName, isPath, out value)) ||
+                            configEntries.TryGetValue(queryName, out value))
                         {
                             yield return value;
                         }
@@ -408,8 +408,8 @@ public IEnumerable<string> GetSettingValues(string envarName, string section, st
                         // `isPath` specified.
                         string scopeWithoutScheme = scope.TrimUntilIndexOf(Uri.SchemeDelimiter);
                         string queryWithSchemeName = $"{section}.{scopeWithoutScheme}.{property}";
-                        if (configEntries.TryGetValue(queryWithSchemeName, out value) &&
-                            (!isPath || config.TryGet(queryWithSchemeName, isPath, out value)))
+                        if ((isPath && config.TryGet(queryWithSchemeName, isPath, out value)) ||
+                            configEntries.TryGetValue(queryWithSchemeName, out value))
                         {
                             yield return value;
                         }