basic: respect new GUI prompt enabled setting

mjcheetham · mjcheetham · commit 735927fc9102 · 2022-01-18T14:56:54.000Z
diff --git a/src/shared/Core/Authentication/BasicAuthentication.cs b/src/shared/Core/Authentication/BasicAuthentication.cs
@@ -32,7 +32,8 @@ public ICredential GetCredentials(string resource, string userName)
             ThrowIfUserInteractionDisabled();
 
             // TODO: we only support system GUI prompts on Windows currently
-            if (Context.SessionManager.IsDesktopSession && PlatformUtils.IsWindows())
+            if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession &&
+                PlatformUtils.IsWindows())
             {
                 return GetCredentialsByUi(resource, userName);
             }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ public ICredential GetCredentials(string resource, string userName)`
`32`	`32`	`ThrowIfUserInteractionDisabled();`
`33`	`33`
`34`	`34`	`// TODO: we only support system GUI prompts on Windows currently`
`35`		`- if (Context.SessionManager.IsDesktopSession && PlatformUtils.IsWindows())`
	`35`	`+ if (Context.Settings.IsGuiPromptsEnabled && Context.SessionManager.IsDesktopSession &&`
	`36`	`+ PlatformUtils.IsWindows())`
`36`	`37`	`{`
`37`	`38`	`return GetCredentialsByUi(resource, userName);`
`38`	`39`	`}`