linux: align with dotnet distros (#953)

Update `install-from-source.sh` and `validate-install-from-source.yml`
to align with dotnet-supported Linux distributions. Clarify in
`README.md` that the dotnet-supported distributions are the only ones
for which GCM guarantees support.

Link to successful validation workflow:


https://github.com/ldennington/git-credential-manager/actions/runs/3415831593

Author: ldennington

.github/workflows/validate-install-from-source.yml

@@ -15,21 +15,29 @@ jobs:
         vector:
         - image: ubuntu
         - image: debian
-        - image: linuxmintd/mint20-amd64
         - image: fedora
-        - image: centos
+        # Centos no longer officially maintains images on Docker Hub. However,
+        # tgagor is a contributor who pushes updated images weekly, which should
+        # be sufficient for our validation needs.
+        - image: tgagor/centos
+        - image: tgagor/centos-stream
         - image: redhat/ubi8
         - image: alpine
+        - image: opensuse/leap
+        - image: opensuse/tumbleweed
+        - image: registry.suse.com/suse/sle15:15.4.27.11.31
+        - image: archlinux
     container: ${{matrix.vector.image}}
     steps:
+      - run: |
+          if [[ ${{matrix.vector.image}} == *"suse"* ]]; then
+            zypper -n install tar gzip
+          elif [[ ${{matrix.vector.image}} == *"centos"* ]]; then
+            dnf install which -y
+          fi       
       - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
         with:
           fetch-depth: 0 # Indicate full history so Nerdbank.GitVersioning works.
       - run: |
-          if [ ${{matrix.vector.image}} == "centos" ]; then
-            sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-Linux-*
-            sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-Linux-*
-          fi
-
           sh "${GITHUB_WORKSPACE}/src/linux/Packaging.Linux/install-from-source.sh" -y
           git-credential-manager --help || exit 1

README.md

@@ -50,14 +50,8 @@ Proxy support|✓|✓|✓
 `arm64` support|best effort|✓|best effort, no packages
 `armhf` support|_N/A_|_N/A_|best effort, no packages
 
-(\*) GCM guarantees support for the below Linux distributions. GCM maintainers
-also monitor and evaluate issues opened against other distributions to determine
-community interest/engagement and whether an emerging platform should become
-fully-supported.
-
-- Debian/Ubuntu/Linux Mint
-- Fedora/CentOS/RHEL
-- Alpine
+(\*) GCM guarantees support only for [the Linux distributions that are officially
+supported by dotnet][dotnet-distributions].
 
 ## Supported Git versions
 
@@ -122,6 +116,7 @@ When using GitHub logos, please be sure to follow the
 [build-status-badge]: https://github.com/GitCredentialManager/git-credential-manager/actions/workflows/continuous-integration.yml/badge.svg
 [docs-index]: https://github.com/GitCredentialManager/git-credential-manager/blob/release/docs/README.md
 [dotnet]: https://dotnet.microsoft.com
+[dotnet-distributions]: https://learn.microsoft.com/en-us/dotnet/core/install/linux
 [git-credential-helper]: https://git-scm.com/docs/gitcredentials
 [gcm]: https://github.com/GitCredentialManager/git-credential-manager
 [gcm-coc]: CODE_OF_CONDUCT.md

src/linux/Packaging.Linux/install-from-source.sh

@@ -41,19 +41,23 @@ Git Credential Manager is licensed under the MIT License: https://aka.ms/gcm/lic
     done
 fi
 
-install_shared_packages() {
+install_packages() {
     pkg_manager=$1
     install_verb=$2
+    packages=$3
 
-    local shared_packages="git curl"
-    for package in $shared_packages; do
+    for package in $packages; do
         # Ensure we don't stomp on existing installations.
         if [ ! -z $(which $package) ]; then
             continue
         fi
 
         if [ $pkg_manager = apk ]; then
             $sudo_cmd $pkg_manager $install_verb $package
+        elif [ $pkg_manager = zypper ]; then
+            $sudo_cmd $pkg_manager -n $install_verb $package
+        elif [ $pkg_manager = pacman ]; then
+            $sudo_cmd $pkg_manager --noconfirm $install_verb $package
         else
             $sudo_cmd $pkg_manager $install_verb $package -y
         fi
@@ -125,7 +129,7 @@ eval "$(sed -n 's/^VERSION_ID=/version=/p' /etc/os-release | tr -d '"')"
 case "$distribution" in
     debian | ubuntu)
         $sudo_cmd apt update
-        install_shared_packages apt install
+        install_packages apt install "curl git"
 
         # Install dotnet packages and dependencies if needed.
         if [ -z "$(verify_existing_dotnet_installation)" ]; then
@@ -150,29 +154,36 @@ case "$distribution" in
             fi
         fi
     ;;
-    linuxmint)
-        $sudo_cmd apt update
-        install_shared_packages apt install
-
-        # Install dotnet packages and dependencies.
-        $sudo_cmd apt install libc6 libgcc1 libgssapi-krb5-2 libssl1.1 libstdc++6 zlib1g libicu66 -y
-        ensure_dotnet_installed
-    ;;
     fedora | centos | rhel)
         $sudo_cmd dnf update -y
-        install_shared_packages dnf install
 
         # Install dotnet/GCM dependencies.
-        $sudo_cmd dnf install krb5-libs libicu openssl-libs zlib findutils which bash -y
+        install_packages dnf install "curl git krb5-libs libicu openssl-libs zlib findutils which bash"
 
         ensure_dotnet_installed
     ;;
     alpine)
         $sudo_cmd apk update
-        install_shared_packages apk add
 
         # Install dotnet/GCM dependencies.
-        $sudo_cmd apk add icu-libs krb5-libs libgcc libintl libssl1.1 libstdc++ zlib which bash coreutils gcompat
+        install_packages apk add "curl git icu-libs krb5-libs libgcc libintl libssl1.1 libstdc++ zlib which bash coreutils gcompat"
+
+        ensure_dotnet_installed
+    ;;
+    sles | opensuse*)
+        $sudo_cmd zypper -n update
+
+        # Install dotnet/GCM dependencies.
+        install_packages zypper install "curl git find krb5 libicu libopenssl1_1"
+
+        ensure_dotnet_installed
+    ;;
+    arch)
+        # --noconfirm required when running from container
+        $sudo_cmd pacman -Syu --noconfirm
+
+        # Install dotnet/GCM dependencies.
+        install_packages pacman -Sy "curl git glibc gcc krb5 icu openssl libc++ zlib"
 
         ensure_dotnet_installed
     ;;