build: explicitly pass version and conf args to pack-tool.sh

Explicitly pass the version and build configuration to the dotnet tool
packaging script. Also revert to a default Debug config for local
builds; this is consistent with all other artifacts in the build for dev
(macOS pkg, Windows installers, deb, etc)

Author: mjcheetham

.github/workflows/release.yml

@@ -620,7 +620,9 @@ jobs:
 
     - name: Package tool
       run: |
-        src/shared/DotnetTool/pack-tool.sh
+        src/shared/DotnetTool/pack-tool.sh \
+          --version=$GitBuildVersionSimple \
+          --configuration=Release
 
     - name: Publish tool
       run: |

src/shared/DotnetTool/pack-tool.sh

@@ -38,7 +38,7 @@ esac
 done
 
 if [ -z "$VERSION" ]; then
-    VERSION="$GitBuildVersionSimple"
+    die "--version was not set"
 fi
 
 # Directories
@@ -54,7 +54,7 @@ DOTNET_TOOL="shared/DotnetTool"
 PROJ_OUT="$OUT/$DOTNET_TOOL"
 
 PACKAGE="$ROOT/nuget"
-CONFIGURATION="${CONFIGURATION:=Release}"
+CONFIGURATION="${CONFIGURATION:=Debug}"
 
 # Build parameters
 FRAMEWORK=net6.0