Skip to content

Commit 85b6104

Browse files
author
Lessley Dennington
committed
release: fix Windows archives
When we transitioned our release workflow to GitHub actions, we started using Powershell's `Compress-Archive` cmdlet to zip our Windows binaries. However, this unfortunately does not play nicely with `unzip` in WSL. Since we're publishing the archives from an Ubuntu machine, switch to creating the archives with the `zip` command in the default bash shell to correct the issue.
1 parent 00244fa commit 85b6104

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,11 +538,10 @@ jobs:
538538
tar -C tmp.osx-arm64-build/symbols -czf osx-payload-and-symbols/gcm-osx-arm64-$GitBuildVersionSimple-symbols.tar.gz .
539539
540540
- name: Archive Windows payload and symbols
541-
shell: pwsh
542541
run: |
543542
mkdir win-x86-payload-and-symbols
544-
Compress-Archive -Path win-sign/signed-payload/* win-x86-payload-and-symbols/gcm-win-x86-$env:GitBuildVersionSimple.zip
545-
Compress-Archive -Path win-sign/src/windows/Installer.Windows/symbols/* win-x86-payload-and-symbols/gcm-win-x86-$env:GitBuildVersionSimple-symbols.zip
543+
zip -jr win-x86-payload-and-symbols/gcm-win-x86-$GitBuildVersionSimple.zip win-sign/signed-payload
544+
zip -jr win-x86-payload-and-symbols/gcm-win-x86-$GitBuildVersionSimple-symbols.zip win-sign/src/windows/Installer.Windows/symbols
546545
547546
- uses: actions/github-script@v6
548547
with:

0 commit comments

Comments
 (0)