fixup! introduce PasswordExpiryUTC and OAuthRefreshToken

Marshal.FreeHGlobal and Marshal.DestroyStructure

Author: hickford

src/shared/Core/Interop/Windows/WindowsCredentialManager.cs

@@ -48,6 +48,8 @@ public void AddOrUpdate(string service, ICredential credential)
 
             IntPtr existingCredPtr = IntPtr.Zero;
             IntPtr credBlob = IntPtr.Zero;
+            IntPtr expiryPtr = IntPtr.Zero;
+            IntPtr attributesPtr = IntPtr.Zero;
 
             try
             {
@@ -101,7 +103,7 @@ public void AddOrUpdate(string service, ICredential credential)
                 if (credential.PasswordExpiry != null)
                 {
                     byte[] expiryBytes = BitConverter.GetBytes(credential.PasswordExpiry.Value.ToUnixTimeSeconds());
-                    IntPtr expiryPtr = Marshal.AllocHGlobal(expiryBytes.Length);
+                    expiryPtr = Marshal.AllocHGlobal(expiryBytes.Length);
                     Marshal.Copy(expiryBytes, 0, expiryPtr, expiryBytes.Length);
 
                     var attribute = new Win32CredentialAttribute()
@@ -113,8 +115,9 @@ public void AddOrUpdate(string service, ICredential credential)
                     };
 
                     newCred.AttributeCount = 1;
-                    newCred.Attributes = Marshal.AllocHGlobal(Marshal.SizeOf(attribute));
-                    Marshal.StructureToPtr(attribute, newCred.Attributes, false);
+                    attributesPtr = Marshal.AllocHGlobal(Marshal.SizeOf(attribute));
+                    Marshal.StructureToPtr(attribute, attributesPtr, false);
+                    newCred.Attributes = attributesPtr;
                 }
 
                 int result = Win32Error.GetLastError(
@@ -134,6 +137,17 @@ public void AddOrUpdate(string service, ICredential credential)
                 {
                     Advapi32.CredFree(existingCredPtr);
                 }
+
+                if (expiryPtr != IntPtr.Zero)
+                {
+                    Marshal.FreeHGlobal(expiryPtr);
+                }
+
+                if (attributesPtr != IntPtr.Zero)
+                {
+                    Marshal.DestroyStructure<Win32CredentialAttribute>(attributesPtr);
+                    Marshal.FreeHGlobal(attributesPtr);
+                }
             }
         }