bitbucket: add unit test for GetCredAsync helper cmdline

Add unit tests for the BitbucketAuthentication command line for UI
helpers.

Author: mjcheetham

src/shared/Atlassian.Bitbucket.Tests/BitbucketAuthenticationTest.cs

@@ -1,6 +1,10 @@
 using System;
+using System.Collections.Generic;
+using System.Threading;
 using System.Threading.Tasks;
+using GitCredentialManager;
 using GitCredentialManager.Tests.Objects;
+using Moq;
 using Xunit;
 
 namespace Atlassian.Bitbucket.Tests
@@ -118,5 +122,113 @@ public async Task BitbucketAuthentication_ShowOAuthRequiredPromptAsync_SucceedsA
             Assert.Equal($"Your account has two-factor authentication enabled.{Environment.NewLine}" +
                                            $"To continue you must complete authentication in your web browser.{Environment.NewLine}", context.Terminal.Messages[0].Item1);
         }
+
+        [Fact]
+        public async Task BitbucketAuthentication_GetCredentialsAsync_AllModes_NoUser_BBCloud_HelperCmdLine()
+        {
+            var targetUri = new Uri("https://bitbucket.org");
+
+            var helperPath = "/usr/bin/test-helper";
+            var expectedUserName = "jsquire";
+            var expectedPassword = "password";
+            var resultDict = new Dictionary<string, string>
+            {
+                ["username"] = expectedUserName,
+                ["password"] = expectedPassword
+            };
+
+            string expectedArgs = $"userpass --show-oauth";
+
+            var context = new TestCommandContext();
+            context.SessionManager.IsDesktopSession = true; // Enable OAuth and UI helper selection
+
+            var authMock = new Mock<BitbucketAuthentication>(context) { CallBase = true };
+            authMock.Setup(x => x.TryFindHelperExecutablePath(out helperPath))
+                .Returns(true);
+            authMock.Setup(x => x.InvokeHelperAsync(It.IsAny<string>(), It.IsAny<string>(), null, CancellationToken.None))
+                .ReturnsAsync(resultDict);
+
+            BitbucketAuthentication auth = authMock.Object;
+            CredentialsPromptResult result = await auth.GetCredentialsAsync(targetUri, null, AuthenticationModes.All);
+
+            Assert.Equal(AuthenticationModes.Basic, result.AuthenticationMode);
+            Assert.Equal(result.Credential.Account, expectedUserName);
+            Assert.Equal(result.Credential.Password, expectedPassword);
+
+            authMock.Verify(x => x.InvokeHelperAsync(helperPath, expectedArgs, null, CancellationToken.None),
+                Times.Once);
+        }
+
+        [Fact]
+        public async Task BitbucketAuthentication_GetCredentialsAsync_BasicOnly_User_BBCloud_HelperCmdLine()
+        {
+            var targetUri = new Uri("https://bitbucket.org");
+
+            var helperPath = "/usr/bin/test-helper";
+            var expectedUserName = "jsquire";
+            var expectedPassword = "password";
+            var resultDict = new Dictionary<string, string>
+            {
+                ["username"] = expectedUserName,
+                ["password"] = expectedPassword
+            };
+
+            string expectedArgs = $"userpass --username {expectedUserName}";
+
+            var context = new TestCommandContext();
+            context.SessionManager.IsDesktopSession = true; // Enable UI helper selection
+
+            var authMock = new Mock<BitbucketAuthentication>(context) { CallBase = true };
+            authMock.Setup(x => x.TryFindHelperExecutablePath(out helperPath))
+                .Returns(true);
+            authMock.Setup(x => x.InvokeHelperAsync(It.IsAny<string>(), It.IsAny<string>(), null, CancellationToken.None))
+                .ReturnsAsync(resultDict);
+
+            BitbucketAuthentication auth = authMock.Object;
+            CredentialsPromptResult result = await auth.GetCredentialsAsync(targetUri, expectedUserName, AuthenticationModes.Basic);
+
+            Assert.Equal(AuthenticationModes.Basic, result.AuthenticationMode);
+            Assert.Equal(result.Credential.Account, expectedUserName);
+            Assert.Equal(result.Credential.Password, expectedPassword);
+
+            authMock.Verify(x => x.InvokeHelperAsync(helperPath, expectedArgs, null, CancellationToken.None),
+                Times.Once);
+        }
+
+        [Fact]
+        public async Task BitbucketAuthentication_GetCredentialsAsync_AllModes_NoUser_BBServerDC_HelperCmdLine()
+        {
+            var targetUri = new Uri("https://example.com/bitbucket");
+
+            var helperPath = "/usr/bin/test-helper";
+            var expectedUserName = "jsquire";
+            var expectedPassword = "password";
+            var resultDict = new Dictionary<string, string>
+            {
+                ["username"] = expectedUserName,
+                ["password"] = expectedPassword
+            };
+
+            string expectedArgs = $"userpass --url {targetUri} --show-oauth";
+
+            var context = new TestCommandContext();
+            context.SessionManager.IsDesktopSession = true; // Enable OAuth and UI helper selection
+
+            var authMock = new Mock<BitbucketAuthentication>(context) { CallBase = true };
+            authMock.Setup(x => x.TryFindHelperExecutablePath(out helperPath))
+                .Returns(true);
+            authMock.Setup(x => x.InvokeHelperAsync(It.IsAny<string>(), It.IsAny<string>(), null, CancellationToken.None))
+                .ReturnsAsync(resultDict);
+
+            BitbucketAuthentication auth = authMock.Object;
+            CredentialsPromptResult result = await auth.GetCredentialsAsync(targetUri, null, AuthenticationModes.All);
+
+            Assert.Equal(AuthenticationModes.Basic, result.AuthenticationMode);
+            Assert.Equal(result.Credential.Account, expectedUserName);
+            Assert.Equal(result.Credential.Password, expectedPassword);
+
+            authMock.Verify(x => x.InvokeHelperAsync(helperPath, expectedArgs, null, CancellationToken.None),
+                Times.Once);
+        }
     }
 }

src/shared/Atlassian.Bitbucket/BitbucketAuthentication.cs

@@ -245,7 +245,7 @@ public async Task<OAuth2TokenResult> RefreshOAuthCredentialsAsync(string refresh
 
         #region Private Methods
 
-        private bool TryFindHelperExecutablePath(out string path)
+        protected internal virtual bool TryFindHelperExecutablePath(out string path)
         {
             return TryFindHelperExecutablePath(
                 BitbucketConstants.EnvironmentVariables.AuthenticationHelper,

src/shared/Atlassian.Bitbucket/InternalsVisibleTo.cs

@@ -0,0 +1,3 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("Atlassian.Bitbucket.Tests")]

src/shared/Core/Authentication/AuthenticationBase.cs

@@ -25,7 +25,7 @@ protected Task<IDictionary<string, string>> InvokeHelperAsync(string path, strin
             return InvokeHelperAsync(path, args, null, CancellationToken.None);
         }
 
-        internal protected virtual async Task<IDictionary<string, string>> InvokeHelperAsync(string path, string args,
+        protected internal virtual async Task<IDictionary<string, string>> InvokeHelperAsync(string path, string args,
             IDictionary<string, string> standardInput, CancellationToken ct)
         {
             var procStartInfo = new ProcessStartInfo(path)

src/shared/Core/InternalsVisibleTo.cs

@@ -2,3 +2,4 @@
 
 [assembly: InternalsVisibleTo("Core.Tests")]
 [assembly: InternalsVisibleTo("GitHub.Tests")]
+[assembly: InternalsVisibleTo("Atlassian.Bitbucket.Tests")]