Skip to content

Commit bf068e1

Browse files
committed
bitbucket: remove separate OAuth prompt/dialog
Remove the separate "OAuth Required" UI prompt in favour of just always showing the "Credentials" prompt, where users can select the OAuth auth mode directly anyway.
1 parent 8e143e0 commit bf068e1

File tree

4 files changed

+252
-338
lines changed

4 files changed

+252
-338
lines changed

src/shared/Atlassian.Bitbucket.Tests/BitbucketAuthenticationTest.cs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,6 @@ public async Task BitbucketAuthentication_GetCredentialsAsync_All_NoDesktopSessi
108108
Assert.Equal(password, result.Credential.Password);
109109
}
110110

111-
[Fact]
112-
public async Task BitbucketAuthentication_ShowOAuthRequiredPromptAsync_SucceedsAfterUserInput()
113-
{
114-
var context = new TestCommandContext();
115-
context.Terminal.Prompts["Press enter to continue..."] = " ";
116-
117-
var bitbucketAuthentication = new BitbucketAuthentication(context);
118-
119-
var result = await bitbucketAuthentication.ShowOAuthRequiredPromptAsync();
120-
121-
Assert.True(result);
122-
Assert.Equal($"Your account has two-factor authentication enabled.{Environment.NewLine}" +
123-
$"To continue you must complete authentication in your web browser.{Environment.NewLine}", context.Terminal.Messages[0].Item1);
124-
}
125-
126111
[Fact]
127112
public async Task BitbucketAuthentication_GetCredentialsAsync_AllModes_NoUser_BBCloud_HelperCmdLine()
128113
{

0 commit comments

Comments
 (0)