Skip to content

Commit e055639

Browse files
authored
install from source: designate arch linux as unsupported (#1291)
Arch Linux was incorrectly added to the install-from-source script and accompanying validation as a .NET-supported distribution, when this is not actually the case. A list of supported distributions can be found here: https://learn.microsoft.com/en-us/dotnet/core/install/linux Instead of removing unsupported distros, we plan to print out a message notifying users that, while they can be installed, they are not officially validated or supported by the GCM project.
2 parents 1b13045 + 00e05eb commit e055639

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

.github/workflows/validate-install-from-source.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
- image: opensuse/leap
2727
- image: opensuse/tumbleweed
2828
- image: registry.suse.com/suse/sle15:15.4.27.11.31
29-
- image: archlinux
3029
container: ${{matrix.vector.image}}
3130
steps:
3231
- run: |

src/linux/Packaging.Linux/install-from-source.sh

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,14 @@ apt_install() {
114114
$sudo_cmd apt install $pkg_name -y 2>/dev/null
115115
}
116116

117+
print_unsupported_distro() {
118+
prefix=$1
119+
distro=$2
120+
121+
echo "$prefix: $distro is not officially supported by the GCM project."
122+
echo "See https://gh.io/gcm/linux for details."
123+
}
124+
117125
sudo_cmd=
118126

119127
# If the user isn't root, we need to use `sudo` for certain commands
@@ -179,6 +187,8 @@ case "$distribution" in
179187
ensure_dotnet_installed
180188
;;
181189
arch)
190+
print_unsupported_distro "WARNING" "$distribution"
191+
182192
# --noconfirm required when running from container
183193
$sudo_cmd pacman -Syu --noconfirm
184194

@@ -188,7 +198,7 @@ case "$distribution" in
188198
ensure_dotnet_installed
189199
;;
190200
*)
191-
echo "ERROR: Unsupported Linux distribution: $distribution"
201+
print_unsupported_distro "ERROR" "$distribution"
192202
exit
193203
;;
194204
esac

0 commit comments

Comments
 (0)