Skip to content

Commit e1bb97a

Browse files
committed
github: fix bug in x-UI cmdline parsing
The System.CommandLine command line binding requires the parameter names match the option names. During the rebasing of the x-platform UI work, the argument name for the `--oauth` option was left as `browser` which means the OAuth browser flow is never shown, even though the base GCM program is passing the right argument/options.
1 parent ff43eeb commit e1bb97a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/shared/GitHub.UI/Commands/CredentialsCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ public CredentialsCommand(ICommandContext context)
3939
Handler = CommandHandler.Create<string, string, bool, bool, bool>(ExecuteAsync);
4040
}
4141

42-
private async Task<int> ExecuteAsync(string enterpriseUrl, string userName, bool basic, bool browser, bool pat)
42+
private async Task<int> ExecuteAsync(string enterpriseUrl, string userName, bool basic, bool oauth, bool pat)
4343
{
4444
var viewModel = new CredentialsViewModel(Context.Environment)
4545
{
46-
ShowBrowserLogin = browser,
46+
ShowBrowserLogin = oauth,
4747
ShowTokenLogin = pat,
4848
ShowBasicLogin = basic,
4949
};

0 commit comments

Comments
 (0)