default OAuth redirect URI to http://127.0.0.1

hickford · hickford · commit ee35d7bf763f · 2023-10-23T21:50:36.000+01:00
diff --git a/docs/generic-oauth.md b/docs/generic-oauth.md
@@ -40,7 +40,7 @@ following values in your Git configuration:
 
 - Client ID
 - Client Secret (optional)
-- Redirect URL
+- Redirect URL (optional, defaults to `http://127.0.0.1`)
 - Scopes (optional)
 - OAuth Endpoints
   - Authorization Endpoint
diff --git a/src/shared/Core/GenericOAuthConfig.cs b/src/shared/Core/GenericOAuthConfig.cs
@@ -81,9 +81,7 @@ public static bool TryGet(ITrace trace, ISettings settings, Uri remoteUri, out G
             }
             else
             {
-                trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}");
-                config = null;
-                return false;
+                config.RedirectUri = new Uri("http://127.0.0.1");
             }
 
             if (settings.TryGetSetting(

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,7 @@ public static bool TryGet(ITrace trace, ISettings settings, Uri remoteUri, out G`
`81`	`81`	`}`
`82`	`82`	`else`
`83`	`83`	`{`
`84`		`- trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}");`
`85`		`- config = null;`
`86`		`- return false;`
	`84`	`+ config.RedirectUri = new Uri("http://127.0.0.1");`
`87`	`85`	`}`
`88`	`86`
`89`	`87`	`if (settings.TryGetSetting(`