Skip to content

Commit 1a72bc6

Browse files
committed
make-file-list: work around 32-bit issues more surgically
As of 6f92a0e (make-file-list: work around 32-bit issues, 2020-10-15), we worked around a discrepancy between i686 and x86_64 variants of the `apr` and the `file` package, excluding dependencies specifically for i686 variants. However, yesterday's big sync removed those discrepancies. Let's use a `grep` invocation that is as straight-forward as it is hacky as an indicator whether or not to special-case these dependencies in the i686 case. All of this is really only needed for this one last time when Git for Windows v2.48.1 will ship with an i686 installer and portable Git; Future versions of Git for Windows will only ship MinGit for that CPU architecture, which does not have that problem. Note that we also have to adjust the `please.sh create-sdk-artifact build-installers` command for that hack to work there. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent c9f04bb commit 1a72bc6

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

make-file-list.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,13 @@ then
187187
mingw-w64-$PACMAN_ARCH-antiword mingw-w64-$PACMAN_ARCH-odt2txt ssh-pageant
188188
mingw-w64-$PACMAN_ARCH-git-lfs mingw-w64-$PACMAN_ARCH-xz tig $GIT_UPDATE_EXTRA_PACKAGES"
189189
fi
190+
191+
I686_EXCLUDE=
192+
if test i686 = "$ARCH" && ! grep msys-uuid-1 /usr/bin/msys-apr-1-0.dll 2>&1 >/dev/null
193+
then
194+
I686_EXCLUDE='uuid\|lzma\|'
195+
fi
196+
190197
pacman_list $packages "$@" |
191198

192199
grep -v -e '\.[acho]$' -e '\.l[ao]$' -e '/aclocal/' \
@@ -234,10 +241,7 @@ grep -v -e '\.[acho]$' -e '\.l[ao]$' -e '/aclocal/' \
234241
-e '^/\(mingw\|clang\)[^/]*/share/gtk-doc/' \
235242
-e '^/\(mingw\|clang\)[^/]*/share/nghttp2/' \
236243
-e '^/usr/bin/msys-\(db\|curl\|icu\|gfortran\|stdc++\|quadmath\)[^/]*\.dll$' \
237-
-e '^/usr/bin/msys-\('$(if test i686 = "$ARCH"
238-
then
239-
echo 'uuid\|lzma\|'
240-
fi)'fdisk\|gettextpo\|gmpxx\|gnutlsxx\|gomp\|xml2\|xslt\|exslt\)-.*\.dll$' \
244+
-e '^/usr/bin/msys-\('"$I686_EXCLUDE"'fdisk\|gettextpo\|gmpxx\|gnutlsxx\|gomp\|xml2\|xslt\|exslt\)-.*\.dll$' \
241245
-e '^/usr/bin/msys-\(hdb\|history8\|kadm5\|kdc\|otp\|sl\).*\.dll$' \
242246
-e '^/usr/bin/msys-\(atomic\|blkid\|charset\|gthread\|metalink\|nghttp2\|ssh2\|kafs\)-.*\.dll$' \
243247
-e '^/usr/bin/msys-\(ncurses++w6\|asprintf-[0-9]*\|\)\.dll$' \

please.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3255,6 +3255,9 @@ create_sdk_artifact () { # [--out=<directory>] [--git-sdk=<directory>] [--archit
32553255
/usr/bin/msys-pcre*.dll
32563256
/usr/bin/msys-gcc_s-*.dll
32573257
3258+
# For the libuuid check
3259+
/usr/bin/msys-apr*.dll
3260+
32583261
# markdown, to render the release notes
32593262
/usr/bin/markdown
32603263

0 commit comments

Comments
 (0)