Skip to content

Commit 9e631f0

Browse files
committed
installer: do show auto-upgraded GCM Core as 'unseen page'
When a user upgrades Git for Windows, having previously chosen Git Credential Manager for Windows (also known as "GCM(W)"), we now upgrade them to Git Credential Manager Core (also known as "GCM Core"). Arguably, this is "a previously unseen option", and therefore the page should be shown when that checkbox to show only such options is checked. We already tried that, but added the wrong thing to the set of pages with unseen options (we need to add the page ID). Signed-off-by: Johannes Schindelin <[email protected]>
1 parent e7dd987 commit 9e631f0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

installer/install.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2137,7 +2137,7 @@ begin
21372137
// Auto-upgrade GCM to GCM Core in version v2.29.0
21382138
if RdbGitCredentialManager[GCM_Classic].Checked and ((PreviousGitForWindowsVersion='') or IsUpgrade('2.29.0')) then begin
21392139
RdbGitCredentialManager[GCM_Core].Checked:=True;
2140-
AddToSet(CustomPagesWithUnseenOptions,GitCredentialManagerPage);
2140+
AddToSet(CustomPagesWithUnseenOptions,GitCredentialManagerPage.ID);
21412141
end;
21422142
end;
21432143

0 commit comments

Comments
 (0)