Skip to content

Commit df56c2c

Browse files
committed
installer: default to GCM Core (including fresh installs)
We just worked on the installer to auto-upgrade existing GCM(W) users to GCM Core. What we did _not_ do is to default new users to GCM Core. D'oh. Noticed by Matthew Cheetham. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 4bb90b5 commit df56c2c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

installer/install.iss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2128,10 +2128,10 @@ begin
21282128
'Enabled': RdbGitCredentialManager[GCM_Classic].Checked:=True;
21292129
'Core': RdbGitCredentialManager[GCM_Core].Checked:=True;
21302130
else
2131-
RdbGitCredentialManager[GCM_Classic].Checked:=True;
2131+
RdbGitCredentialManager[GCM_Core].Checked:=True;
21322132
end;
21332133
// Auto-upgrade GCM to GCM Core in version v2.29.0
2134-
if RdbGitCredentialManager[GCM_Classic].Checked and (PreviousGitForWindowsVersion<>'') and IsDowngrade(PreviousGitForWindowsVersion,'2.29.0') then begin
2134+
if RdbGitCredentialManager[GCM_Classic].Checked and ((PreviousGitForWindowsVersion='') or IsDowngrade(PreviousGitForWindowsVersion,'2.29.0')) then begin
21352135
RdbGitCredentialManager[GCM_Core].Checked:=True;
21362136
AddToSet(CustomPagesWithUnseenOptions,GitCredentialManagerPage);
21372137
end;

0 commit comments

Comments
 (0)