Skip to content

Commit f6f802b

Browse files
committed
please.sh upgrade msys2-runtime: fix logic to determine up-to-date-ness
The `please.sh` script has a rather simple logic to determine whether a new package should be built or not: comparing the timestamps of the latest commits of the `msys2-runtime` repository and of the `msys2-runtime/` subdirectory of the `MSYS2-packages` repository. However, what we need to look for is a commit in `MSYS2-packages` that changed either `pkgrel` or `pkgver` in `msys2-runtime/PKGBUILD`. Let's do that. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent a8ee932 commit f6f802b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

please.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2743,7 +2743,7 @@ upgrade () { # [--directory=<artifacts-directory>] [--only-mingw] [--no-build] [
27432743
msys2_runtime_mtime=$(git log -1 --format=%ct \
27442744
git-for-windows/main --) &&
27452745
msys2_package_mtime=$(git -C ../.. log -1 \
2746-
--format=%ct -- .) &&
2746+
--format=%ct -G'pkg(rel|ver)' -- PKGBUILD) &&
27472747
test $msys2_runtime_mtime -gt $msys2_package_mtime
27482748
;;
27492749
esac ||

0 commit comments

Comments
 (0)