Skip to content

Commit 496cfb1

Browse files
committed
Remove the obsolete code to trigger Azure Pipelines
Git for Windows has been using GitHub workflows instead, ever since #29 was merged. Therefore, the code to trigger Azure Pipelines has not been in use for almost two years. It's time to retire it. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 64b47fb commit 496cfb1

File tree

3 files changed

+3
-198
lines changed

3 files changed

+3
-198
lines changed

GitForWindowsHelper/azure-pipelines.js

Lines changed: 0 additions & 193 deletions
This file was deleted.

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ For convenience, the command can be abbreviated as `/add relnote <type> <message
5555

5656
**Where can it be called?** In `git-for-windows/git`'s [Pull Requests](https://github.com/git-for-windows/git/pulls)
5757

58-
**What does it do?** This command starts [the `Git artifacts` Azure Pipeline](https://dev.azure.com/git-for-windows/git/_build?definitionId=34&_a=summary) that builds all of the artifacts of a full Git for Windows release: installer, Portable Git, MinGit, etc
58+
**What does it do?** This command starts [the `git-artifacts` workflow](https://github.com/git-for-windows/git-for-windows-automation/actions/workflows/git-artifacts.yml) that builds all of the artifacts of a full Git for Windows release: installer, Portable Git, MinGit, etc
5959

6060
### `/release`
6161

6262
**Where can it be called?** In `git-for-windows/git`'s [Pull Requests](https://github.com/git-for-windows/git/pulls)
6363

64-
**What does it do?** Call this command after a `/git-artifacts` command successfully produced the artifacts _and_ after the installer artifact has been validated manually, using [the "pre-flight checklist"](https://github.com/git-for-windows/build-extra/blob/HEAD/installer/checklist.txt). This will start [the Azure Release Pipeline](https://dev.azure.com/git-for-windows/git/_release?_a=releases&view=mine&definitionId=1) to publish the artifacts in a new GitHub Release.
64+
**What does it do?** Call this command after a `/git-artifacts` command successfully produced the artifacts _and_ after the installer artifact has been validated manually, using [the "pre-flight checklist"](https://github.com/git-for-windows/build-extra/blob/HEAD/installer/checklist.txt). This will start [the `release-git` workflow](https://github.com/git-for-windows/git-for-windows-automation/actions/workflows/release-git.yml) to publish the artifacts in a new GitHub Release.
6565

6666
## Spinning up Windows/ARM64 runners
6767

@@ -94,7 +94,6 @@ Then, configure [the `GITHUB_*` variables](#some-environment-variables) locally,
9494
"IsEncrypted": false,
9595
"Values": {
9696
"FUNCTIONS_WORKER_RUNTIME": "node",
97-
"AZURE_PIPELINE_TRIGGER_TOKEN": "<personal-access-token>",
9897
"AzureWebJobsStorage": "<storage-key>",
9998
"GITHUB_APP_ID": "<app-id>",
10099
"GITHUB_APP_CLIENT_ID": "<client-id>",
@@ -128,7 +127,7 @@ After the deployment succeeded, in the "Overview" tab, there is a "Get publish p
128127

129128
A few environment variables will have to be configured for use with the Azure Function. This can be done on the "Configuration" tab, which is in the "Settings" group.
130129

131-
Concretely, the environment variables `AZURE_PIPELINE_TRIGGER_TOKEN`, `GITHUB_WEBHOOK_SECRET`, `GITHUB_APP_PRIVATE_KEY`, `GITHUB_APP_CLIENT_SECRET`, `GITHUB_APP_CLIENT_ID` and `GITHUB_APP_ID` need to be set. For the first, a generated random string was used. The private key, client secret and ID of the GitHub App are not known at this time, though, therefore they will have to be set in the Azure Function Configuration later.
130+
Concretely, the environment variables `GITHUB_WEBHOOK_SECRET`, `GITHUB_APP_PRIVATE_KEY`, `GITHUB_APP_CLIENT_SECRET`, `GITHUB_APP_CLIENT_ID` and `GITHUB_APP_ID` need to be set. For the first, a generated random string was used. The private key, client secret and ID of the GitHub App are not known at this time, though, therefore they will have to be set in the Azure Function Configuration later.
132131

133132
### The repository
134133

test-pr-comment-delivery.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@
6969

7070
// avoid accidentally triggering anything
7171
delete process.env.GITHUB_APP_PRIVATE_KEY
72-
delete process.env.AZURE_PIPELINE_TRIGGER_TOKEN
7372
process.env.DO_NOT_TRIGGER_ANYTHING = 'true'
7473

7574
const index = require('./GitForWindowsHelper/index')

0 commit comments

Comments
 (0)