Retire the Azure Pipeline trigger #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason why some of the settings are disabled in this script is so that no state is changed on github.com when debugging a webhook payload event locally. However, in some cases the GitForWindowsHelper app needs to query GitHub's REST API using an access token because some queries cannot be issued without authorization. For example, for some reason or other reading workflow runs' logs requires a token (which is different than what Azure Pipelines does, from which GitHub Actions were derived, so this is doubly curious). To help with such debugging scenarios, have a separate way to prevent specifically triggering workflow runs, which would be the worst thing to do inadvertently during a debugging session. By default, the private key and Azure Pipelines trigger token are still disabled in the script, but now it is at least somewhat safe to comment out the private key disabling so that above-mentioned queries can be debugged locally. Signed-off-by: Johannes Schindelin <[email protected]>
Git for Windows has been using GitHub workflows instead, ever since #29 was merged. Therefore, the code to trigger Azure Pipelines has not been in use for almost two years. It's time to retire it. Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #29 GitForWindowsHelper has not triggered any Azure Pipeline.