prepare-embargoed-branches: special-case some older release trains #131
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `[^0-9]` shell pattern is not portable to Dash, which we use in the GitHub automation. Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
reviewed
Jul 13, 2025
prepare-embargoed-branches.sh
Outdated
| previous_version_prefix=2.46.2 | ||
| ;; | ||
| 2.47.2) | ||
| # There was no Git for Windows v2.47.3, so we use v2.47.1(2) |
There was a problem hiding this comment.
Actually, no... This switch case is about the previous version, that is, the script is called with v2.47.3 and previous_version will then be set to 2.47.2...
There was a problem hiding this comment.
Yes, the switch seems to be correct, but the comment claims that 2.47.3 didn't exist, whereas the code special cases 2.47.2 not existing.
There was a problem hiding this comment.
Aaah! You are right. Fixed.
These two versions do not have _strict_ predecessors in Git for Windows, as Git for Windows v2.46.3 and v2.47.2 were never released. Let's special-case these two versions so that we can prepare embargoed branches for them, too. We simply use the closest preceding Git for Windows versions that _were_ released. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
prepare-embargoed-branches-for-old-versions
branch
from
c3f204a to
62979d5
Compare
rimrul
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to release some security bug fix releases recently that did not quite follow a previous version. For example, there was a gap between Git for Windows v2.47.1(2) and MinGit v2.47.3 (there was no Git for Windows nor MinGit v2.47.2).
To accommodate for this, I came up with these patches (and used them in the private repository where the embargoed releases were built).