self-hosted runners: use latest pwsh version now that arm64 MSIs are available
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available Starting with version 7.4.3 of PowerShell, Windows arm64 MSIs are added to the releases, so we no longer need to hardcode the preview version. Ref: https://github.com/PowerShell/PowerShell/releases/tag/v7.4.3 Signed-off-by: Dennis Ameling <[email protected]>
During local testing, I forgot to run PowerShell as administrator and the installation of `pwsh` silently failed. Let's prevent the script from starting if we're not an admin. Ref: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_requires?view=powershell-7.4#-runasadministrator Signed-off-by: Dennis Ameling <[email protected]>
rimrul
approved these changes
Sep 12, 2024
dscho
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version 7.4.3 of PowerShell, Windows arm64 MSIs are added to the releases, so we no longer need to hardcode the preview version.
Also, during local testing, I forgot to run PowerShell as administrator and the installation of
pwshsilently failed. Let's prevent the script from starting if we're not an admin. This is mostly a nice to have for local testing, since the post-deployment script on the self-hosted runner always runs as admin.